From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:49743)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1b9o81-0007ZP-EM
	for qemu-devel@nongnu.org; Mon, 06 Jun 2016 02:35:14 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1b9o7w-0007I2-9Y
	for qemu-devel@nongnu.org; Mon, 06 Jun 2016 02:35:12 -0400
Received: from mx1.redhat.com ([209.132.183.28]:51493)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1b9o7w-0007Hl-4Y
	for qemu-devel@nongnu.org; Mon, 06 Jun 2016 02:35:08 -0400
Received: from int-mx11.intmail.prod.int.phx2.redhat.com
	(int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by mx1.redhat.com (Postfix) with ESMTPS id B98FB65400
	for <qemu-devel@nongnu.org>; Mon,  6 Jun 2016 06:35:06 +0000 (UTC)
Message-ID: <1465194905.24775.180.camel@redhat.com>
From: Gerd Hoffmann <kraxel@redhat.com>
Date: Mon, 06 Jun 2016 08:35:05 +0200
In-Reply-To: <1465076003-26291-12-git-send-email-marcandre.lureau@redhat.com>
References: <1465076003-26291-1-git-send-email-marcandre.lureau@redhat.com>
	<1465076003-26291-12-git-send-email-marcandre.lureau@redhat.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Mime-Version: 1.0
Subject: Re: [Qemu-devel] [RFC 11/14] console: add dpy_gl_scanout2()
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: marcandre.lureau@redhat.com
Cc: qemu-devel@nongnu.org

  Hi,

> @@ -218,6 +218,11 @@ typedef struct DisplayChangeListenerOps {
>      void (*dpy_gl_scanout)(DisplayChangeListener *dcl,
>                             uint32_t backing_id, bool backing_y_0_top,
>                             uint32_t x, uint32_t y, uint32_t w, uint32_t =
h);
> +    void (*dpy_gl_scanout2)(DisplayChangeListener *dcl,
> +                            int fd, bool backing_y_0_top,
> +                            uint32_t x, uint32_t y, uint32_t w, uint32_t=
 h,
> +                            uint32_t fd_w, uint32_t fd_h, uint32_t fd_st=
ride,
> +                            int fd_fourcc);

Interface looks sane.  I'd like to see a more descriptive name than just
"2" though.  Maybe "dpy_gl_scanout_dmabuf"?  And while being at it
rename the other one to "dpy_gl_scanout_texture"?

Also: please put the spice update into a separate patch.

Adding gtk (or sdl2, or both) support would be nice, to see whenever the
interface works if qemu needs to import the dma-buf for display.

cheers,
  Gerd