From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36707) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b9qgQ-0005jr-8K for qemu-devel@nongnu.org; Mon, 06 Jun 2016 05:18:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b9qgL-0001pQ-4E for qemu-devel@nongnu.org; Mon, 06 Jun 2016 05:18:53 -0400 Received: from mx1.redhat.com ([209.132.183.28]:55658) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b9qgK-0001pM-Uy for qemu-devel@nongnu.org; Mon, 06 Jun 2016 05:18:49 -0400 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 646017F6A2 for ; Mon, 6 Jun 2016 09:18:48 +0000 (UTC) From: Gerd Hoffmann Date: Mon, 6 Jun 2016 11:18:45 +0200 Message-Id: <1465204725-31562-1-git-send-email-kraxel@redhat.com> Subject: [Qemu-devel] [PATCH] vnc: drop unused depth arg for set_pixel_format List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Gerd Hoffmann , Paolo Bonzini Spotted by Coverity. Cc: Paolo Bonzini Signed-off-by: Gerd Hoffmann --- ui/vnc.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/ui/vnc.c b/ui/vnc.c index c862fdc..942cfb9 100644 --- a/ui/vnc.c +++ b/ui/vnc.c @@ -2115,8 +2115,7 @@ static void send_color_map(VncState *vs) } } -static void set_pixel_format(VncState *vs, - int bits_per_pixel, int depth, +static void set_pixel_format(VncState *vs, int bits_per_pixel, int big_endian_flag, int true_color_flag, int red_max, int green_max, int blue_max, int red_shift, int green_shift, int blue_shift) @@ -2124,7 +2123,6 @@ static void set_pixel_format(VncState *vs, if (!true_color_flag) { /* Expose a reasonable default 256 color map */ bits_per_pixel = 8; - depth = 8; red_max = 7; green_max = 7; blue_max = 3; @@ -2231,7 +2229,7 @@ static int protocol_client_msg(VncState *vs, uint8_t *data, size_t len) if (len == 1) return 20; - set_pixel_format(vs, read_u8(data, 4), read_u8(data, 5), + set_pixel_format(vs, read_u8(data, 4), read_u8(data, 6), read_u8(data, 7), read_u16(data, 8), read_u16(data, 10), read_u16(data, 12), read_u8(data, 14), -- 1.8.3.1