From: "Denis V. Lunev" <den@openvz.org>
To: qemu-devel@nongnu.org
Cc: den@openvz.org, Paolo Bonzini <pbonzini@redhat.com>,
Gerd Hoffmann <kraxel@redhat.com>
Subject: [Qemu-devel] [PATCH 1/1] vnc: remove unused depth argument in set_pixel_format
Date: Mon, 6 Jun 2016 12:51:30 +0300 [thread overview]
Message-ID: <1465206690-4721-1-git-send-email-den@openvz.org> (raw)
Spotted by coverity, reported by Paolo.
Signed-off-by: Denis V. Lunev <den@openvz.org>
CC: Paolo Bonzini <pbonzini@redhat.com>
CC: Gerd Hoffmann <kraxel@redhat.com>
---
ui/vnc.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/ui/vnc.c b/ui/vnc.c
index c862fdc..cc94024 100644
--- a/ui/vnc.c
+++ b/ui/vnc.c
@@ -2116,7 +2116,7 @@ static void send_color_map(VncState *vs)
}
static void set_pixel_format(VncState *vs,
- int bits_per_pixel, int depth,
+ int bits_per_pixel,
int big_endian_flag, int true_color_flag,
int red_max, int green_max, int blue_max,
int red_shift, int green_shift, int blue_shift)
@@ -2124,7 +2124,6 @@ static void set_pixel_format(VncState *vs,
if (!true_color_flag) {
/* Expose a reasonable default 256 color map */
bits_per_pixel = 8;
- depth = 8;
red_max = 7;
green_max = 7;
blue_max = 3;
@@ -2231,7 +2230,7 @@ static int protocol_client_msg(VncState *vs, uint8_t *data, size_t len)
if (len == 1)
return 20;
- set_pixel_format(vs, read_u8(data, 4), read_u8(data, 5),
+ set_pixel_format(vs, read_u8(data, 4),
read_u8(data, 6), read_u8(data, 7),
read_u16(data, 8), read_u16(data, 10),
read_u16(data, 12), read_u8(data, 14),
--
2.5.0
next reply other threads:[~2016-06-06 9:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-06 9:51 Denis V. Lunev [this message]
2016-06-15 15:07 ` [Qemu-devel] [PATCH 1/1] vnc: remove unused depth argument in set_pixel_format Denis V. Lunev
2016-06-15 15:10 ` Paolo Bonzini
2016-06-15 15:11 ` Denis V. Lunev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1465206690-4721-1-git-send-email-den@openvz.org \
--to=den@openvz.org \
--cc=kraxel@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).