From: Igor Mammedov <imammedo@redhat.com>
To: qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, ehabkost@redhat.com,
mark.cave-ayland@ilande.co.uk, blauwirbel@gmail.com,
qemu-arm@nongnu.org, pbonzini@redhat.com, rth@twiddle.net
Subject: [Qemu-devel] [PATCH 07/10] target-sparc: cpu: use sparc_cpu_parse_features() directly
Date: Mon, 6 Jun 2016 17:16:49 +0200 [thread overview]
Message-ID: <1465226212-254093-8-git-send-email-imammedo@redhat.com> (raw)
In-Reply-To: <1465226212-254093-1-git-send-email-imammedo@redhat.com>
make SPARC target use sparc_cpu_parse_features() directly
so it won't get in the way of switching other propertified
targets to handling features as global properties.
Signed-off-by: Igor Mammedov <imammedo@redhat.com>
---
SPARC target could be switched to features properties
later but that would need quite a bit of refactoring
in generating necessary CPU types and adding appropriate
properties.
---
target-sparc/cpu.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/target-sparc/cpu.c b/target-sparc/cpu.c
index 5b74cfc..e4089f2 100644
--- a/target-sparc/cpu.c
+++ b/target-sparc/cpu.c
@@ -101,9 +101,11 @@ static void cpu_sparc_disas_set_info(CPUState *cpu, disassemble_info *info)
#endif
}
+static void sparc_cpu_parse_features(CPUState *cs, char *features,
+ Error **errp);
+
static int cpu_sparc_register(SPARCCPU *cpu, const char *cpu_model)
{
- CPUClass *cc = CPU_GET_CLASS(cpu);
CPUSPARCState *env = &cpu->env;
char *s = g_strdup(cpu_model);
char *featurestr, *name = strtok(s, ",");
@@ -119,7 +121,7 @@ static int cpu_sparc_register(SPARCCPU *cpu, const char *cpu_model)
memcpy(env->def, def, sizeof(*def));
featurestr = strtok(NULL, ",");
- cc->parse_features(CPU(cpu), featurestr, &err);
+ sparc_cpu_parse_features(CPU(cpu), featurestr, &err);
g_free(s);
if (err) {
error_report_err(err);
@@ -840,7 +842,6 @@ static void sparc_cpu_class_init(ObjectClass *oc, void *data)
scc->parent_reset = cc->reset;
cc->reset = sparc_cpu_reset;
- cc->parse_features = sparc_cpu_parse_features;
cc->has_work = sparc_cpu_has_work;
cc->do_interrupt = sparc_cpu_do_interrupt;
cc->cpu_exec_interrupt = sparc_cpu_exec_interrupt;
--
1.8.3.1
next prev parent reply other threads:[~2016-06-06 15:17 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-06 15:16 [Qemu-devel] [PATCH 00/10] cpus: make "-cpu cpux, features" global properties Igor Mammedov
2016-06-06 15:16 ` [Qemu-devel] [PATCH 01/10] target-i386: Remove xlevel & hv-spinlocks option fixups Igor Mammedov
2016-06-06 15:16 ` [Qemu-devel] [PATCH 02/10] target-i386: cpu: move features logic that requires CPUState to realize time Igor Mammedov
2016-06-07 20:25 ` Eduardo Habkost
2016-06-07 21:07 ` Eric Blake
2016-06-07 22:29 ` Eduardo Habkost
2016-06-06 15:16 ` [Qemu-devel] [PATCH 03/10] target-i386: cpu: move xcc->kvm_required check " Igor Mammedov
2016-06-07 20:23 ` Eduardo Habkost
2016-06-07 20:28 ` Eduardo Habkost
2016-06-09 18:34 ` Eduardo Habkost
2016-06-10 7:15 ` Igor Mammedov
2016-06-10 11:39 ` Eduardo Habkost
2016-06-10 11:48 ` [Qemu-devel] [PATCH] target-i386: Remove assert(kvm_enabled()) from host_x86_cpu_initfn() Eduardo Habkost
2016-06-10 12:40 ` Igor Mammedov
2016-06-06 15:16 ` [Qemu-devel] [PATCH 04/10] target-i386: cpu: use cpu_generic_init() in cpu_x86_init() Igor Mammedov
2016-06-07 20:29 ` Eduardo Habkost
2016-06-06 15:16 ` [Qemu-devel] [PATCH 05/10] target-i386: cpu: consolidate calls of object_property_parse() in x86_cpu_parse_featurestr Igor Mammedov
2016-06-07 20:37 ` Eduardo Habkost
2016-06-06 15:16 ` [Qemu-devel] [PATCH 06/10] target-i386: print obsolete warnings if +-features are used Igor Mammedov
2016-06-07 11:44 ` Paolo Bonzini
2016-06-07 12:32 ` Igor Mammedov
2016-06-07 12:36 ` Paolo Bonzini
2016-06-07 12:54 ` Igor Mammedov
2016-06-07 13:00 ` Paolo Bonzini
2016-06-07 13:26 ` Igor Mammedov
2016-06-07 15:17 ` Eduardo Habkost
2016-06-06 15:16 ` Igor Mammedov [this message]
2016-06-08 16:30 ` [Qemu-devel] [PATCH 07/10] target-sparc: cpu: use sparc_cpu_parse_features() directly Eduardo Habkost
2016-06-10 11:51 ` Eduardo Habkost
2016-06-10 18:32 ` Mark Cave-Ayland
2016-06-06 15:16 ` [Qemu-devel] [PATCH 08/10] cpu: use CPUClass->parse_features() as convertor to global properties Igor Mammedov
2016-06-08 16:47 ` Eduardo Habkost
2016-06-09 12:38 ` Igor Mammedov
2016-06-09 13:23 ` Eduardo Habkost
2016-06-09 13:40 ` Igor Mammedov
2016-06-06 15:16 ` [Qemu-devel] [PATCH 09/10] arm: virt: parse cpu_model only once Igor Mammedov
2016-06-08 16:55 ` Eduardo Habkost
2016-06-08 17:25 ` Peter Maydell
2016-06-06 15:16 ` [Qemu-devel] [PATCH 10/10] pc: parse cpu features " Igor Mammedov
2016-06-08 17:03 ` Eduardo Habkost
2016-06-09 12:07 ` Igor Mammedov
2016-06-09 13:25 ` Eduardo Habkost
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1465226212-254093-8-git-send-email-imammedo@redhat.com \
--to=imammedo@redhat.com \
--cc=blauwirbel@gmail.com \
--cc=ehabkost@redhat.com \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).