From: Eduardo Habkost <ehabkost@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Jiri Denemark" <jdenemar@redhat.com>,
"Andreas Färber" <afaerber@suse.de>,
"Igor Mammedov" <imammedo@redhat.com>,
libvir-list@redhat.com,
"David Hildenbrand" <dahi@linux.vnet.ibm.com>,
"Michael Mueller" <mimu@linux.vnet.ibm.com>,
"Christian Borntraeger" <borntraeger@de.ibm.com>,
"Cornelia Huck" <cornelia.huck@de.ibm.com>
Subject: [Qemu-devel] [PATCH v2 4/6] qmp: Add runnability information to query-cpu-definitions
Date: Mon, 6 Jun 2016 17:05:41 -0300 [thread overview]
Message-ID: <1465243543-889-5-git-send-email-ehabkost@redhat.com> (raw)
In-Reply-To: <1465243543-889-1-git-send-email-ehabkost@redhat.com>
Extend query-cpu-definitions schema to allow it to return two new
optional fields: "runnable" and "unavailable-features".
"runnable" will tell if the CPU model can be run in the current
host. "unavailable-features" will contain a list of CPU
properties that are preventing the CPU model from running in the
current host.
Cc: David Hildenbrand <dahi@linux.vnet.ibm.com>
Cc: Michael Mueller <mimu@linux.vnet.ibm.com>
Cc: Christian Borntraeger <borntraeger@de.ibm.com>
Cc: Cornelia Huck <cornelia.huck@de.ibm.com>
Cc: Jiri Denemark <jdenemar@redhat.com>
Cc: libvir-list@redhat.com
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
---
Changes v1 -> v2:
* Remove @runnable field, non-empty @unavailable-features is
enough to report CPU model as not runnable.
* Documentation updates:
* Changed to "(since 2.7)";
* Add more details about the exact meaning of
unavailable-features, and what it would mean to see
read-only QOM properties in the list, and that
implementations can return "type" if there's
no extra information available;
---
qapi-schema.json | 23 ++++++++++++++++++++++-
1 file changed, 22 insertions(+), 1 deletion(-)
diff --git a/qapi-schema.json b/qapi-schema.json
index 8483bdf..43478e9 100644
--- a/qapi-schema.json
+++ b/qapi-schema.json
@@ -3005,11 +3005,32 @@
# Virtual CPU definition.
#
# @name: the name of the CPU definition
+# @unavailable-features: #optional List of properties that prevent
+# the CPU model from running in the current
+# host. (since 2.7)
+#
+# @unavailable-features is a list of QOM property names that
+# represent CPU model attributes that prevent the CPU from running.
+# If the QOM property is read-only, that means there's no known
+# way to make the CPU model run in the current host. If
+# absolutely no extra information will be returned to explain why
+# the CPU model is not runnable, implementations may simply
+# return "type" as the property name.
+# If the property is read-write, it means that it MAY be possible
+# to run the CPU model in the current host if that property is
+# changed. Management software can use it as hints to suggest or
+# choose an alternative for the user, or just to generate meaningful
+# error messages explaining why the CPU model can't be used.
+# If @unavailable-features is an empty list, the CPU model is
+# runnable using the current host and machine-type.
+# If @unavailable-features is not present, runnability
+# information for the CPU is not available.
#
# Since: 1.2.0
##
{ 'struct': 'CpuDefinitionInfo',
- 'data': { 'name': 'str' } }
+ 'data': { 'name': 'str',
+ '*unavailable-features': [ 'str' ] } }
##
# @query-cpu-definitions:
--
2.5.5
next prev parent reply other threads:[~2016-06-06 20:06 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-06 20:05 [Qemu-devel] [PATCH v2 0/6] Add runnability info to query-cpu-definitions Eduardo Habkost
2016-06-06 20:05 ` [Qemu-devel] [PATCH v2 1/6] target-i386: List CPU models using subclass list Eduardo Habkost
2016-06-06 20:05 ` [Qemu-devel] [PATCH v2 2/6] target-i386: Move warning code outside x86_cpu_filter_features() Eduardo Habkost
2016-06-06 20:05 ` [Qemu-devel] [PATCH v2 3/6] target-i386: Define CPUID filtering functions before x86_cpu_list() Eduardo Habkost
2016-06-06 20:05 ` Eduardo Habkost [this message]
2016-06-09 13:54 ` [Qemu-devel] [PATCH v2 4/6] qmp: Add runnability information to query-cpu-definitions Jiri Denemark
2016-06-09 13:57 ` Eduardo Habkost
2016-06-22 9:00 ` Markus Armbruster
2016-06-22 17:15 ` Eduardo Habkost
2016-06-23 7:10 ` Markus Armbruster
2016-06-06 20:05 ` [Qemu-devel] [PATCH v2 5/6] target-i386: Use "-" instead of "_" on all feature names Eduardo Habkost
2016-06-06 20:05 ` [Qemu-devel] [PATCH v2 6/6] target-i386: Return runnability information on query-cpu-definitions Eduardo Habkost
2016-06-20 20:09 ` [Qemu-devel] [PATCH v2 0/6] Add runnability info to query-cpu-definitions Eduardo Habkost
2016-06-21 13:16 ` Jiri Denemark
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1465243543-889-5-git-send-email-ehabkost@redhat.com \
--to=ehabkost@redhat.com \
--cc=afaerber@suse.de \
--cc=borntraeger@de.ibm.com \
--cc=cornelia.huck@de.ibm.com \
--cc=dahi@linux.vnet.ibm.com \
--cc=imammedo@redhat.com \
--cc=jdenemar@redhat.com \
--cc=libvir-list@redhat.com \
--cc=mimu@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).