qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Peter Lieven <pl@kamp.de>
To: qemu-devel@nongnu.org
Cc: jasowang@redhat.com, s.priebe@profihost.ag,
	Peter Lieven <pl@kamp.de>,
	qemu-stable@nongnu.org, yanghy@cn.fujitsu.com
Subject: [Qemu-devel] [PATCH] net: fix qemu_announce_self not emitting packets
Date: Tue,  7 Jun 2016 09:37:44 +0200	[thread overview]
Message-ID: <1465285064-24833-1-git-send-email-pl@kamp.de> (raw)

commit fefe2a78 accidently dropped the code path for injecting
raw packets. This feature is needed for sending gratuitous ARPs
after an incoming migration has completed. The result is increased
network downtime for vservers where the network card is not virtio-net
with the VIRTIO_NET_F_GUEST_ANNOUNCE feature.

Fixes: fefe2a78abde932e0f340b21bded2c86def1d242
Cc: qemu-stable@nongnu.org
Cc: yanghy@cn.fujitsu.com
Signed-off-by: Peter Lieven <pl@kamp.de>
---
 net/net.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/net/net.c b/net/net.c
index 5f3e5a9..d5834ea 100644
--- a/net/net.c
+++ b/net/net.c
@@ -722,7 +722,11 @@ ssize_t qemu_deliver_packet_iov(NetClientState *sender,
         return 0;
     }
 
-    if (nc->info->receive_iov) {
+    if (flags & QEMU_NET_PACKET_FLAG_RAW && iovcnt == 1 &&
+        nc->info->receive_raw) {
+        /* this is required for qemu_announce_self() */
+        ret = nc->info->receive_raw(nc, iov[0].iov_base, iov[0].iov_len);
+    } else  if (nc->info->receive_iov) {
         ret = nc->info->receive_iov(nc, iov, iovcnt);
     } else {
         ret = nc_sendv_compat(nc, iov, iovcnt, flags);
-- 
1.9.1

             reply	other threads:[~2016-06-07  7:38 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-07  7:37 Peter Lieven [this message]
2016-06-07  7:55 ` [Qemu-devel] [PATCH] net: fix qemu_announce_self not emitting packets Paolo Bonzini
2016-06-07  8:02   ` Peter Lieven
2016-06-07  8:23     ` Paolo Bonzini
2016-06-07  9:33 ` Stefan Priebe - Profihost AG
2016-06-07 11:35 ` Yang Hongyang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1465285064-24833-1-git-send-email-pl@kamp.de \
    --to=pl@kamp.de \
    --cc=jasowang@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-stable@nongnu.org \
    --cc=s.priebe@profihost.ag \
    --cc=yanghy@cn.fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).