* [Qemu-devel] [PATCH v2] Makefile: add dependency on scripts/create_config
@ 2016-06-07 12:07 Paolo Bonzini
2016-06-07 12:13 ` Peter Maydell
0 siblings, 1 reply; 2+ messages in thread
From: Paolo Bonzini @ 2016-06-07 12:07 UTC (permalink / raw)
To: qemu-devel
Make sure that config-host.h and config-target.h are rebuilt whenever
there is a change in the scripts that generates them; add the dependency
to the pattern rule as suggested by Peter.
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
rules.mak | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/rules.mak b/rules.mak
index 4a8f464..fae16b3 100644
--- a/rules.mak
+++ b/rules.mak
@@ -172,7 +172,7 @@ TRACETOOL=$(PYTHON) $(SRC_PATH)/scripts/tracetool.py
config-%.h: config-%.h-timestamp
@cmp $< $@ >/dev/null 2>&1 || cp $< $@
-config-%.h-timestamp: config-%.mak
+config-%.h-timestamp: config-%.mak $(SRC_PATH)/scripts/create_config
$(call quiet-command, sh $(SRC_PATH)/scripts/create_config < $< > $@, " GEN $(TARGET_DIR)config-$*.h")
.PHONY: clean-timestamp
--
1.8.3.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Qemu-devel] [PATCH v2] Makefile: add dependency on scripts/create_config
2016-06-07 12:07 [Qemu-devel] [PATCH v2] Makefile: add dependency on scripts/create_config Paolo Bonzini
@ 2016-06-07 12:13 ` Peter Maydell
0 siblings, 0 replies; 2+ messages in thread
From: Peter Maydell @ 2016-06-07 12:13 UTC (permalink / raw)
To: Paolo Bonzini; +Cc: QEMU Developers
On 7 June 2016 at 13:07, Paolo Bonzini <pbonzini@redhat.com> wrote:
> Make sure that config-host.h and config-target.h are rebuilt whenever
> there is a change in the scripts that generates them; add the dependency
> to the pattern rule as suggested by Peter.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> rules.mak | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/rules.mak b/rules.mak
> index 4a8f464..fae16b3 100644
> --- a/rules.mak
> +++ b/rules.mak
> @@ -172,7 +172,7 @@ TRACETOOL=$(PYTHON) $(SRC_PATH)/scripts/tracetool.py
> config-%.h: config-%.h-timestamp
> @cmp $< $@ >/dev/null 2>&1 || cp $< $@
>
> -config-%.h-timestamp: config-%.mak
> +config-%.h-timestamp: config-%.mak $(SRC_PATH)/scripts/create_config
> $(call quiet-command, sh $(SRC_PATH)/scripts/create_config < $< > $@, " GEN $(TARGET_DIR)config-$*.h")
>
> .PHONY: clean-timestamp
> --
> 1.8.3.1
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
thanks
-- PMM
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-06-07 12:13 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-06-07 12:07 [Qemu-devel] [PATCH v2] Makefile: add dependency on scripts/create_config Paolo Bonzini
2016-06-07 12:13 ` Peter Maydell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).