qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Hajnoczi <stefanha@redhat.com>
To: qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>,
	Fam Zheng <famz@redhat.com>,
	Stefan Hajnoczi <stefanha@redhat.com>
Subject: [Qemu-devel] [PULL 02/12] blockdev-backup: Use bdrv_lookup_bs on target
Date: Tue,  7 Jun 2016 15:26:15 +0100	[thread overview]
Message-ID: <1465309585-31551-3-git-send-email-stefanha@redhat.com> (raw)
In-Reply-To: <1465309585-31551-1-git-send-email-stefanha@redhat.com>

From: Fam Zheng <famz@redhat.com>

This allows backing up to a BDS that has not been attached to any BB.

Signed-off-by: Fam Zheng <famz@redhat.com>
Message-id: 1463969978-24970-2-git-send-email-famz@redhat.com
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
---
 blockdev.c | 13 +++----------
 1 file changed, 3 insertions(+), 10 deletions(-)

diff --git a/blockdev.c b/blockdev.c
index 717785e..ea7f397 100644
--- a/blockdev.c
+++ b/blockdev.c
@@ -3335,7 +3335,7 @@ void do_blockdev_backup(const char *device, const char *target,
                          BlockdevOnError on_target_error,
                          BlockJobTxn *txn, Error **errp)
 {
-    BlockBackend *blk, *target_blk;
+    BlockBackend *blk;
     BlockDriverState *bs;
     BlockDriverState *target_bs;
     Error *local_err = NULL;
@@ -3366,18 +3366,11 @@ void do_blockdev_backup(const char *device, const char *target,
     }
     bs = blk_bs(blk);
 
-    target_blk = blk_by_name(target);
-    if (!target_blk) {
-        error_setg(errp, "Device '%s' not found", target);
+    target_bs = bdrv_lookup_bs(target, target, errp);
+    if (!target_bs) {
         goto out;
     }
 
-    if (!blk_is_available(target_blk)) {
-        error_setg(errp, "Device '%s' has no medium", target);
-        goto out;
-    }
-    target_bs = blk_bs(target_blk);
-
     bdrv_set_aio_context(target_bs, aio_context);
     backup_start(bs, target_bs, speed, sync, NULL, on_source_error,
                  on_target_error, block_job_cb, bs, txn, &local_err);
-- 
2.5.5

  parent reply	other threads:[~2016-06-07 14:26 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-07 14:26 [Qemu-devel] [PULL 00/12] Block patches Stefan Hajnoczi
2016-06-07 14:26 ` [Qemu-devel] [PULL 01/12] tests: avoid coroutine pool test crash Stefan Hajnoczi
2016-06-07 14:26 ` Stefan Hajnoczi [this message]
2016-06-07 14:26 ` [Qemu-devel] [PULL 03/12] blockdev-backup: Don't move target AioContext if it's attached Stefan Hajnoczi
2016-06-07 14:26 ` [Qemu-devel] [PULL 04/12] virtio-blk: Remove op blocker for dataplane Stefan Hajnoczi
2016-06-07 14:26 ` [Qemu-devel] [PULL 05/12] virtio-scsi: " Stefan Hajnoczi
2016-06-07 14:26 ` [Qemu-devel] [PULL 06/12] virtio: drop duplicate virtio_queue_get_id() function Stefan Hajnoczi
2016-06-07 14:26 ` [Qemu-devel] [PULL 07/12] block/io: Remove unused bdrv_aio_write_zeroes() Stefan Hajnoczi
2016-06-07 14:26 ` [Qemu-devel] [PULL 08/12] iostatus: fix comments for block_job_iostatus_reset Stefan Hajnoczi
2016-06-07 14:26 ` [Qemu-devel] [PULL 09/12] block/io: optimize bdrv_co_pwritev for small requests Stefan Hajnoczi
2016-06-07 14:26 ` [Qemu-devel] [PULL 10/12] block: Move BlockRequest type to io.c Stefan Hajnoczi
2016-06-07 14:26 ` [Qemu-devel] [PULL 11/12] block: Drop bdrv_ioctl_bh_cb Stefan Hajnoczi
2016-06-07 14:26 ` [Qemu-devel] [PULL 12/12] throttle: refuse iops-size without iops-total/read/write Stefan Hajnoczi
2016-06-07 15:34 ` [Qemu-devel] [PULL 00/12] Block patches Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1465309585-31551-3-git-send-email-stefanha@redhat.com \
    --to=stefanha@redhat.com \
    --cc=famz@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).