From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60755) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bAZjr-0002VA-Ay for qemu-devel@nongnu.org; Wed, 08 Jun 2016 05:25:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bAZjp-0003n9-EK for qemu-devel@nongnu.org; Wed, 08 Jun 2016 05:25:26 -0400 Received: from mx1.redhat.com ([209.132.183.28]:58077) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bAZjp-0003mx-9K for qemu-devel@nongnu.org; Wed, 08 Jun 2016 05:25:25 -0400 From: Stefan Hajnoczi Date: Tue, 7 Jun 2016 17:28:29 +0100 Message-Id: <1465316911-20052-6-git-send-email-stefanha@redhat.com> In-Reply-To: <1465316911-20052-1-git-send-email-stefanha@redhat.com> References: <1465316911-20052-1-git-send-email-stefanha@redhat.com> Subject: [Qemu-devel] [PATCH v3 5/7] virtio-blk: live migrate s->rq with multiqueue List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Kevin Wolf , Roman Pen , Fam Zheng , Christian Borntraeger , Paolo Bonzini , Ming Lei , Stefan Hajnoczi Add a field for the virtqueue index when migrating the s->rq request list. The new field is only needed when num_queues > 1. Existing QEMUs are unaffected by this change and therefore virtio-blk migration stays compatible. Suggested-by: Paolo Bonzini Signed-off-by: Stefan Hajnoczi --- hw/block/virtio-blk.c | 20 +++++++++++++++++++- 1 file changed, 19 insertions(+), 1 deletion(-) diff --git a/hw/block/virtio-blk.c b/hw/block/virtio-blk.c index 222611c..6f122cf 100644 --- a/hw/block/virtio-blk.c +++ b/hw/block/virtio-blk.c @@ -813,6 +813,11 @@ static void virtio_blk_save_device(VirtIODevice *vdev, QEMUFile *f) while (req) { qemu_put_sbyte(f, 1); + + if (s->conf.num_queues > 1) { + qemu_put_be32(f, virtio_queue_get_id(req->vq)); + } + qemu_put_virtqueue_element(f, &req->elem); req = req->next; } @@ -836,9 +841,22 @@ static int virtio_blk_load_device(VirtIODevice *vdev, QEMUFile *f, VirtIOBlock *s = VIRTIO_BLK(vdev); while (qemu_get_sbyte(f)) { + unsigned nvqs = s->conf.num_queues; + unsigned vq_idx = 0; VirtIOBlockReq *req; + + if (nvqs > 1) { + vq_idx = qemu_get_be32(f); + + if (vq_idx >= nvqs) { + error_report("Invalid virtqueue index in request list: %#x", + vq_idx); + return -EINVAL; + } + } + req = qemu_get_virtqueue_element(f, sizeof(VirtIOBlockReq)); - virtio_blk_init_request(s, s->vq, req); + virtio_blk_init_request(s, virtio_get_queue(vdev, vq_idx), req); req->next = s->rq; s->rq = req; } -- 2.5.5