qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Huth <thuth@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>,
	Stefan Weil <sw@weilnetz.de>,
	qemu-devel@nongnu.org
Cc: Stefan Hajnoczi <stefanha@redhat.com>,
	"Daniel P. Berrange" <berrange@redhat.com>,
	Paolo Bonzini <pbonzini@redhat.com>,
	Yuri Pudgorodskiy <yur@virtuozzo.com>
Subject: [Qemu-devel] [RFC PATCH] configure: Enable -Werror for MinGW builds, too
Date: Wed,  8 Jun 2016 10:13:26 +0200	[thread overview]
Message-ID: <1465373606-18486-1-git-send-email-thuth@redhat.com> (raw)

MinGW seems to compile currently without warnings, so it should
be safe to enable -Werror now for this environment, too.

Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 ... at least it compiles without errors for me here. I hope that's
 also true for different versions of MinGW ... would be great if
 everybody who has such a compiler installed could give it a try!

 configure | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/configure b/configure
index 4627d2c..2e5b818 100755
--- a/configure
+++ b/configure
@@ -1393,7 +1393,7 @@ z_version=$(cut -f3 -d. $source_path/VERSION)
 
 if test -z "$werror" ; then
     if test -d "$source_path/.git" -a \
-        "$linux" = "yes" ; then
+        \( "$linux" = "yes" -o "$mingw32" = "yes" \) ; then
         werror="yes"
     else
         werror="no"
-- 
1.8.3.1

             reply	other threads:[~2016-06-08  8:13 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-08  8:13 Thomas Huth [this message]
2016-06-08  8:45 ` [Qemu-devel] [RFC PATCH] configure: Enable -Werror for MinGW builds, too Daniel P. Berrange
2016-06-08 14:09 ` Stefan Hajnoczi
2016-06-08 18:55   ` Peter Maydell
2016-06-08 19:52     ` Stefan Weil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1465373606-18486-1-git-send-email-thuth@redhat.com \
    --to=thuth@redhat.com \
    --cc=berrange@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    --cc=sw@weilnetz.de \
    --cc=yur@virtuozzo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).