* [Qemu-devel] [PATCH] Makefile: Fix tag file generation targets
@ 2016-06-09 17:58 Sergey Fedorov
2016-06-13 9:30 ` Paolo Bonzini
0 siblings, 1 reply; 2+ messages in thread
From: Sergey Fedorov @ 2016-06-09 17:58 UTC (permalink / raw)
To: qemu-devel
Cc: qemu-trivial, patches, Sergey Fedorov, Sergey Fedorov,
Michael Roth, Paolo Bonzini, Daniel P. Berrange,
Marc-André Lureau, Michael Tokarev
From: Sergey Fedorov <serge.fdrv@gmail.com>
"ctags" produces a file named "tags", not "ctags". It doesn't look
reasonable to use phony target name as a file name to remove. Just use
exact file names to remove in "ctags" and "TAGS" target receipts.
Signed-off-by: Sergey Fedorov <serge.fdrv@gmail.com>
Signed-off-by: Sergey Fedorov <sergey.fedorov@linaro.org>
---
Makefile | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/Makefile b/Makefile
index b8563db68677..61bf1bf9e2bb 100644
--- a/Makefile
+++ b/Makefile
@@ -478,12 +478,12 @@ test speed: all
.PHONY: ctags
ctags:
- rm -f $@
+ rm -f tags
find "$(SRC_PATH)" -name '*.[hc]' -exec ctags --append {} +
.PHONY: TAGS
TAGS:
- rm -f $@
+ rm -f TAGS
find "$(SRC_PATH)" -name '*.[hc]' -exec etags --append {} +
cscope:
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Qemu-devel] [PATCH] Makefile: Fix tag file generation targets
2016-06-09 17:58 [Qemu-devel] [PATCH] Makefile: Fix tag file generation targets Sergey Fedorov
@ 2016-06-13 9:30 ` Paolo Bonzini
0 siblings, 0 replies; 2+ messages in thread
From: Paolo Bonzini @ 2016-06-13 9:30 UTC (permalink / raw)
To: Sergey Fedorov, qemu-devel
Cc: qemu-trivial, patches, Sergey Fedorov, Michael Roth,
Daniel P. Berrange, Marc-André Lureau, Michael Tokarev
On 09/06/2016 19:58, Sergey Fedorov wrote:
> From: Sergey Fedorov <serge.fdrv@gmail.com>
>
> "ctags" produces a file named "tags", not "ctags". It doesn't look
> reasonable to use phony target name as a file name to remove. Just use
> exact file names to remove in "ctags" and "TAGS" target receipts.
>
> Signed-off-by: Sergey Fedorov <serge.fdrv@gmail.com>
> Signed-off-by: Sergey Fedorov <sergey.fedorov@linaro.org>
> ---
> Makefile | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Makefile b/Makefile
> index b8563db68677..61bf1bf9e2bb 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -478,12 +478,12 @@ test speed: all
>
> .PHONY: ctags
> ctags:
> - rm -f $@
> + rm -f tags
> find "$(SRC_PATH)" -name '*.[hc]' -exec ctags --append {} +
>
> .PHONY: TAGS
> TAGS:
> - rm -f $@
> + rm -f TAGS
> find "$(SRC_PATH)" -name '*.[hc]' -exec etags --append {} +
>
> cscope:
>
Queued, thanks.
Paolo
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-06-13 9:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-06-09 17:58 [Qemu-devel] [PATCH] Makefile: Fix tag file generation targets Sergey Fedorov
2016-06-13 9:30 ` Paolo Bonzini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).