qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Bharata B Rao <bharata@linux.vnet.ibm.com>
To: qemu-devel@nongnu.org
Cc: qemu-ppc@nongnu.org, david@gibson.dropbear.id.au,
	imammedo@redhat.com, thuth@redhat.com, aik@ozlabs.ru,
	agraf@suse.de, pbonzini@redhat.com, ehabkost@redhat.com,
	pkrempa@redhat.com, mdroth@linux.vnet.ibm.com, eblake@redhat.com,
	mjrosato@linux.vnet.ibm.com, borntraeger@de.ibm.com,
	Bharata B Rao <bharata@linux.vnet.ibm.com>
Subject: [Qemu-devel] [PATCH v4 0/9] Core based CPU hotplug for PowerPC sPAPR
Date: Fri, 10 Jun 2016 06:28:59 +0530	[thread overview]
Message-ID: <1465520348-13964-1-git-send-email-bharata@linux.vnet.ibm.com> (raw)

Hi,

This is the next version of the CPU hotplug patchset for PowerPC
sPAPR target. The hotplug semantics looks like this:

(qemu) device_add POWER8E-spapr-cpu-core,id=core2,core-id=16[,threads=4]
(qemu) device_add host-spapr-cpu-core,id=core2,core-id=16[,threads=4]
(qemu) device_add POWER8E_v2.1-spapr-cpu-core,id=core2,core-id=16[,threads=4]

Changes in v4
-------------
- Rebased against David Gibson's ppc-cpu-hotplug and hence dropped those
  patches that are already part of that tree.
- We were assuming the CPU thread to be always of type PowerPCCPU which
  needn't be true. Hence use actual CPU type's instance_size when
  object_initialize'ing the threads as per David's suggestion. This requires
  us to know the instance_size for a given type for which a new QOM API
  object_type_get_size() has been introduced in this version.
- Consolidate CPU init related routines in spapr_cpu_core.c. As part of this
  move spapr_cpu_init() and its dependencies to spapr_cpu_core.c.
- Got rid of the temporary unplug list when removing CPU cores.
- Folded spapr_cpu_core_create_threads() into spapr_cpu_core_realize() and
  fixed the error path in in spapr_cpu_core_realize().
- Add support for -cpu host.

TODOs remaining
---------------
- Work on David's suggestion of intializing CPU's ObjectClass in
  class_init rather than instance_init.
- Use object_initialize_with_type instead of object_initialize when
  creating CPU threads of a core.
- Use vcpu_dt_id logic when populating core id in
  spapr_query_hotpluggable_cpus().
- Handle CPU compat properly (-cpu host,compat=POWER7)

v3: https://lists.gnu.org/archive/html/qemu-devel/2016-05/msg01829.html

Bharata B Rao (7):
  qom: API to get instance_size of a type
  spapr: Abstract CPU core device and type specific core devices
  spapr: Move spapr_cpu_init() to spapr_cpu_core.c
  spapr: convert boot CPUs into CPU core devices
  spapr: CPU hotplug support
  spapr: CPU hot unplug support
  hmp: Add 'info hotpluggable-cpus' HMP command

Igor Mammedov (2):
  QMP: Add query-hotpluggable-cpus
  spapr: implement query-hotpluggable-cpus callback

 hmp-commands-info.hx            |  14 ++
 hmp.c                           |  41 ++++
 hmp.h                           |   1 +
 hw/ppc/Makefile.objs            |   1 +
 hw/ppc/spapr.c                  | 215 +++++++++++++++------
 hw/ppc/spapr_cpu_core.c         | 405 ++++++++++++++++++++++++++++++++++++++++
 hw/ppc/spapr_events.c           |   3 +
 hw/ppc/spapr_rtas.c             |  24 +++
 include/hw/boards.h             |   5 +
 include/hw/ppc/spapr.h          |   7 +
 include/hw/ppc/spapr_cpu_core.h |  36 ++++
 include/qom/object.h            |   8 +-
 monitor.c                       |  13 ++
 qapi-schema.json                |  55 ++++++
 qmp-commands.hx                 |  23 +++
 qom/object.c                    |   8 +
 target-ppc/kvm.c                |  28 +++
 17 files changed, 828 insertions(+), 59 deletions(-)
 create mode 100644 hw/ppc/spapr_cpu_core.c
 create mode 100644 include/hw/ppc/spapr_cpu_core.h

-- 
2.1.0

             reply	other threads:[~2016-06-10  0:59 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-10  0:58 Bharata B Rao [this message]
2016-06-10  0:59 ` [Qemu-devel] [PATCH v4 1/9] qom: API to get instance_size of a type Bharata B Rao
2016-06-10  4:04   ` David Gibson
2016-06-10  7:38     ` Igor Mammedov
2016-06-15  5:48       ` David Gibson
2016-06-10  0:59 ` [Qemu-devel] [PATCH v4 2/9] spapr: Abstract CPU core device and type specific core devices Bharata B Rao
2016-06-10  4:24   ` David Gibson
2016-06-10  0:59 ` [Qemu-devel] [PATCH v4 3/9] spapr: Move spapr_cpu_init() to spapr_cpu_core.c Bharata B Rao
2016-06-10  4:27   ` David Gibson
2016-06-10  0:59 ` [Qemu-devel] [PATCH v4 4/9] spapr: convert boot CPUs into CPU core devices Bharata B Rao
2016-06-10  0:59 ` [Qemu-devel] [PATCH v4 5/9] spapr: CPU hotplug support Bharata B Rao
2016-06-10  0:59 ` [Qemu-devel] [PATCH v4 6/9] spapr: CPU hot unplug support Bharata B Rao
2016-06-10  0:59 ` [Qemu-devel] [PATCH v4 7/9] QMP: Add query-hotpluggable-cpus Bharata B Rao
2016-06-10  0:59 ` [Qemu-devel] [PATCH v4 8/9] hmp: Add 'info hotpluggable-cpus' HMP command Bharata B Rao
2016-06-10  8:34   ` David Gibson
2016-06-10  0:59 ` [Qemu-devel] [PATCH v4 9/9] spapr: implement query-hotpluggable-cpus callback Bharata B Rao
2016-06-10  5:14 ` [Qemu-devel] [PATCH v4 0/9] Core based CPU hotplug for PowerPC sPAPR David Gibson
2016-06-15  6:04   ` [Qemu-devel] [Qemu-ppc] " David Gibson
2016-06-16  3:49     ` Bharata B Rao
2016-06-16  6:41       ` David Gibson
2016-06-16 11:49       ` Thomas Huth
2016-06-16 16:57         ` Igor Mammedov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1465520348-13964-1-git-send-email-bharata@linux.vnet.ibm.com \
    --to=bharata@linux.vnet.ibm.com \
    --cc=agraf@suse.de \
    --cc=aik@ozlabs.ru \
    --cc=borntraeger@de.ibm.com \
    --cc=david@gibson.dropbear.id.au \
    --cc=eblake@redhat.com \
    --cc=ehabkost@redhat.com \
    --cc=imammedo@redhat.com \
    --cc=mdroth@linux.vnet.ibm.com \
    --cc=mjrosato@linux.vnet.ibm.com \
    --cc=pbonzini@redhat.com \
    --cc=pkrempa@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).