* [Qemu-devel] [PATCH] ui: fix regression in printing VNC host/port on startup
@ 2016-06-08 10:42 Daniel P. Berrange
2016-06-08 13:35 ` Eric Blake
2016-06-10 9:11 ` Gerd Hoffmann
0 siblings, 2 replies; 3+ messages in thread
From: Daniel P. Berrange @ 2016-06-08 10:42 UTC (permalink / raw)
To: qemu-devel
Cc: qemu-trivial, qemu-stable, Gerd Hoffmann, Dr. David Alan Gilbert,
Daniel P. Berrange
If VNC is chosen as the compile time default display backend,
QEMU will print the host/port it listens on at startup.
Previously this would look like
VNC server running on '::1:5900'
but in 04d2529da27db512dcbd5e99d0e26d333f16efcc the ':' was
accidentally replaced with a ';'. This the ':' back.
Reported-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
---
ui/vnc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ui/vnc.c b/ui/vnc.c
index c862fdc..75ae2a7 100644
--- a/ui/vnc.c
+++ b/ui/vnc.c
@@ -3225,7 +3225,7 @@ char *vnc_display_local_addr(const char *id)
qapi_free_SocketAddress(addr);
return NULL;
}
- ret = g_strdup_printf("%s;%s", addr->u.inet.data->host,
+ ret = g_strdup_printf("%s:%s", addr->u.inet.data->host,
addr->u.inet.data->port);
qapi_free_SocketAddress(addr);
--
2.5.5
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH] ui: fix regression in printing VNC host/port on startup
2016-06-08 10:42 [Qemu-devel] [PATCH] ui: fix regression in printing VNC host/port on startup Daniel P. Berrange
@ 2016-06-08 13:35 ` Eric Blake
2016-06-10 9:11 ` Gerd Hoffmann
1 sibling, 0 replies; 3+ messages in thread
From: Eric Blake @ 2016-06-08 13:35 UTC (permalink / raw)
To: Daniel P. Berrange, qemu-devel
Cc: qemu-trivial, qemu-stable, Dr. David Alan Gilbert, Gerd Hoffmann
[-- Attachment #1: Type: text/plain, Size: 1225 bytes --]
On 06/08/2016 04:42 AM, Daniel P. Berrange wrote:
> If VNC is chosen as the compile time default display backend,
> QEMU will print the host/port it listens on at startup.
> Previously this would look like
>
> VNC server running on '::1:5900'
>
> but in 04d2529da27db512dcbd5e99d0e26d333f16efcc the ':' was
> accidentally replaced with a ';'. This the ':' back.
>
> Reported-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
> ---
> ui/vnc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Eric Blake <eblake@redhat.com>
>
> diff --git a/ui/vnc.c b/ui/vnc.c
> index c862fdc..75ae2a7 100644
> --- a/ui/vnc.c
> +++ b/ui/vnc.c
> @@ -3225,7 +3225,7 @@ char *vnc_display_local_addr(const char *id)
> qapi_free_SocketAddress(addr);
> return NULL;
> }
> - ret = g_strdup_printf("%s;%s", addr->u.inet.data->host,
> + ret = g_strdup_printf("%s:%s", addr->u.inet.data->host,
> addr->u.inet.data->port);
> qapi_free_SocketAddress(addr);
>
>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH] ui: fix regression in printing VNC host/port on startup
2016-06-08 10:42 [Qemu-devel] [PATCH] ui: fix regression in printing VNC host/port on startup Daniel P. Berrange
2016-06-08 13:35 ` Eric Blake
@ 2016-06-10 9:11 ` Gerd Hoffmann
1 sibling, 0 replies; 3+ messages in thread
From: Gerd Hoffmann @ 2016-06-10 9:11 UTC (permalink / raw)
To: Daniel P. Berrange
Cc: qemu-devel, qemu-trivial, qemu-stable, Dr. David Alan Gilbert
On Mi, 2016-06-08 at 11:42 +0100, Daniel P. Berrange wrote:
> If VNC is chosen as the compile time default display backend,
> QEMU will print the host/port it listens on at startup.
> Previously this would look like
>
> VNC server running on '::1:5900'
>
> but in 04d2529da27db512dcbd5e99d0e26d333f16efcc the ':' was
> accidentally replaced with a ';'. This the ':' back.
Added to ui queue.
thanks,
Gerd
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-06-10 9:11 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-06-08 10:42 [Qemu-devel] [PATCH] ui: fix regression in printing VNC host/port on startup Daniel P. Berrange
2016-06-08 13:35 ` Eric Blake
2016-06-10 9:11 ` Gerd Hoffmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).