From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37283) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bBJDN-0000tC-FN for qemu-devel@nongnu.org; Fri, 10 Jun 2016 05:59:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bBJDE-0007Ju-Rv for qemu-devel@nongnu.org; Fri, 10 Jun 2016 05:58:56 -0400 Received: from mx1.redhat.com ([209.132.183.28]:49828) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bBJDE-0007J2-Mv for qemu-devel@nongnu.org; Fri, 10 Jun 2016 05:58:48 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 694B2382F for ; Fri, 10 Jun 2016 09:58:46 +0000 (UTC) From: Gerd Hoffmann Date: Fri, 10 Jun 2016 11:58:39 +0200 Message-Id: <1465552722-14567-3-git-send-email-kraxel@redhat.com> In-Reply-To: <1465552722-14567-1-git-send-email-kraxel@redhat.com> References: <1465552722-14567-1-git-send-email-kraxel@redhat.com> Subject: [Qemu-devel] [PULL 2/5] ui: fix regression in printing VNC host/port on startup List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: "Daniel P. Berrange" , Gerd Hoffmann From: "Daniel P. Berrange" If VNC is chosen as the compile time default display backend, QEMU will print the host/port it listens on at startup. Previously this would look like VNC server running on '::1:5900' but in 04d2529da27db512dcbd5e99d0e26d333f16efcc the ':' was accidentally replaced with a ';'. This the ':' back. Reported-by: Dr. David Alan Gilbert Signed-off-by: Daniel P. Berrange Reviewed-by: Eric Blake Message-id: 1465382576-25552-1-git-send-email-berrange@redhat.com Signed-off-by: Gerd Hoffmann --- ui/vnc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ui/vnc.c b/ui/vnc.c index 942cfb9..95e4db7 100644 --- a/ui/vnc.c +++ b/ui/vnc.c @@ -3223,7 +3223,7 @@ char *vnc_display_local_addr(const char *id) qapi_free_SocketAddress(addr); return NULL; } - ret = g_strdup_printf("%s;%s", addr->u.inet.data->host, + ret = g_strdup_printf("%s:%s", addr->u.inet.data->host, addr->u.inet.data->port); qapi_free_SocketAddress(addr); -- 1.8.3.1