From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56372) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bBUSg-0001AA-5d for qemu-devel@nongnu.org; Fri, 10 Jun 2016 17:59:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bBUSf-0000od-8E for qemu-devel@nongnu.org; Fri, 10 Jun 2016 17:59:30 -0400 From: John Snow Date: Fri, 10 Jun 2016 17:59:21 -0400 Message-Id: <1465595961-4762-1-git-send-email-jsnow@redhat.com> Subject: [Qemu-devel] [PATCH] block-backend: allow flush on devices with open tray List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-block@nongnu.org Cc: kwolf@redhat.com, qemu-devel@nongnu.org, mreitz@redhat.com, John Snow If a device still has an attached BDS because the medium has not yet been removed, we will be unable to migrate to a new host because blk_flush will return an error for that backend. Replace the call to blk_is_available to blk_is_inserted to weaken the check and allow flushes from the backend to work, while still disallowing flushes from the frontend/device model to work. This fixes a regression present in 2.6.0 caused by the following commit: fe1a9cbc339bb54d20f1ca4c1e8788d16944d5cf block: Move some bdrv_*_all() functions to BB Signed-off-by: John Snow --- block/block-backend.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block/block-backend.c b/block/block-backend.c index 34500e6..d1e875e 100644 --- a/block/block-backend.c +++ b/block/block-backend.c @@ -1122,7 +1122,7 @@ int blk_co_flush(BlockBackend *blk) int blk_flush(BlockBackend *blk) { - if (!blk_is_available(blk)) { + if (!blk_is_inserted(blk)) { return -ENOMEDIUM; } -- 2.4.11