From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53787) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bCQJW-000646-UT for qemu-devel@nongnu.org; Mon, 13 Jun 2016 07:45:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bCQJQ-0005wU-Qf for qemu-devel@nongnu.org; Mon, 13 Jun 2016 07:45:54 -0400 Received: from mx1.redhat.com ([209.132.183.28]:33808) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bCQJQ-0005wO-L7 for qemu-devel@nongnu.org; Mon, 13 Jun 2016 07:45:48 -0400 From: "Daniel P. Berrange" Date: Mon, 13 Jun 2016 12:45:35 +0100 Message-Id: <1465818337-30627-3-git-send-email-berrange@redhat.com> In-Reply-To: <1465818337-30627-1-git-send-email-berrange@redhat.com> References: <1465818337-30627-1-git-send-email-berrange@redhat.com> Subject: [Qemu-devel] [PULL v1 2/4] crypto: remove temp files on completion of secrets test List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Peter Maydell , "Daniel P. Berrange" The secret object tests left some temporary files on disk when completing. Ensure they are unlink, and rename them to make it more obvious where they come from. Signed-off-by: Daniel P. Berrange --- tests/test-crypto-secret.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/tests/test-crypto-secret.c b/tests/test-crypto-secret.c index 0b1fe8d..13fc6c4 100644 --- a/tests/test-crypto-secret.c +++ b/tests/test-crypto-secret.c @@ -49,7 +49,7 @@ static void test_secret_indirect_good(void) { Object *sec; char *fname = NULL; - int fd = g_file_open_tmp("secretXXXXXX", + int fd = g_file_open_tmp("qemu-test-crypto-secret-XXXXXX", &fname, NULL); @@ -74,6 +74,7 @@ static void test_secret_indirect_good(void) object_unparent(sec); g_free(pw); close(fd); + unlink(fname); g_free(fname); } @@ -96,7 +97,7 @@ static void test_secret_indirect_emptyfile(void) { Object *sec; char *fname = NULL; - int fd = g_file_open_tmp("secretXXXXXX", + int fd = g_file_open_tmp("qemu-test-crypto-secretXXXXXX", &fname, NULL); @@ -119,6 +120,7 @@ static void test_secret_indirect_emptyfile(void) object_unparent(sec); g_free(pw); close(fd); + unlink(fname); g_free(fname); } -- 2.5.5