qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Hajnoczi <stefanha@redhat.com>
To: qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>,
	jjherne@linux.vnet.ibm.com, Fam Zheng <famz@redhat.com>,
	Paolo Bonzini <pbonzini@redhat.com>, Jeff Cody <jcody@redhat.com>,
	mreitz@redhat.com, Stefan Hajnoczi <stefanha@redhat.com>
Subject: [Qemu-devel] [PATCH v3 12/15] blockjob: move iostatus reset out of block_job_enter()
Date: Mon, 13 Jun 2016 18:05:32 +0100	[thread overview]
Message-ID: <1465837535-30067-13-git-send-email-stefanha@redhat.com> (raw)
In-Reply-To: <1465837535-30067-1-git-send-email-stefanha@redhat.com>

The QMP block-job-resume command and cancellation may want to reset the
job's iostatus.  The next patches add a user who does not want to reset
iostatus so move it up to block_job_enter() callers.

Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
---
 blockdev.c | 1 +
 blockjob.c | 2 +-
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/blockdev.c b/blockdev.c
index 7fd515a..19b963c 100644
--- a/blockdev.c
+++ b/blockdev.c
@@ -3799,6 +3799,7 @@ void qmp_block_job_resume(const char *device, Error **errp)
 
     job->user_paused = false;
     trace_qmp_block_job_resume(job);
+    block_job_iostatus_reset(job);
     block_job_resume(job);
     aio_context_release(aio_context);
 }
diff --git a/blockjob.c b/blockjob.c
index c095cc5..463bccf 100644
--- a/blockjob.c
+++ b/blockjob.c
@@ -269,7 +269,6 @@ void block_job_resume(BlockJob *job)
 
 void block_job_enter(BlockJob *job)
 {
-    block_job_iostatus_reset(job);
     if (job->co && !job->busy) {
         qemu_coroutine_enter(job->co, NULL);
     }
@@ -278,6 +277,7 @@ void block_job_enter(BlockJob *job)
 void block_job_cancel(BlockJob *job)
 {
     job->cancelled = true;
+    block_job_iostatus_reset(job);
     block_job_enter(job);
 }
 
-- 
2.5.5

  parent reply	other threads:[~2016-06-13 17:06 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-13 17:05 [Qemu-devel] [PATCH v3 00/15] mirror: follow AioContext change gracefully Stefan Hajnoczi
2016-06-13 17:05 ` [Qemu-devel] [PATCH v3 01/15] translate-all.c: Don't pass puc, locked to tb_invalidate_phys_page() Stefan Hajnoczi
2016-06-13 17:05 ` [Qemu-devel] [PATCH v3 02/15] user-exec: Push resume-from-signal code out to handle_cpu_signal() Stefan Hajnoczi
2016-06-13 17:05 ` [Qemu-devel] [PATCH v3 03/15] cpu-exec: Rename cpu_resume_from_signal() to cpu_loop_exit_noexc() Stefan Hajnoczi
2016-06-13 17:05 ` [Qemu-devel] [PATCH v3 04/15] user-exec: Don't reextract sigmask from usercontext pointer Stefan Hajnoczi
2016-06-13 17:05 ` [Qemu-devel] [PATCH v3 05/15] target-i386: Add comment about do_interrupt_user() next_eip argument Stefan Hajnoczi
2016-06-13 17:05 ` [Qemu-devel] [PATCH v3 06/15] target-i386: Move user-mode exception actions out of user-exec.c Stefan Hajnoczi
2016-06-13 17:05 ` [Qemu-devel] [PATCH v3 07/15] vnc: drop unused depth arg for set_pixel_format Stefan Hajnoczi
2016-06-13 17:05 ` [Qemu-devel] [PATCH v3 08/15] ui: fix regression in printing VNC host/port on startup Stefan Hajnoczi
2016-06-13 17:05 ` [Qemu-devel] [PATCH v3 09/15] gtk: fix vte version check Stefan Hajnoczi
2016-06-13 17:05 ` [Qemu-devel] [PATCH v3 10/15] ui/console-gl: Add support for big endian display surfaces Stefan Hajnoczi
2016-06-13 17:05 ` [Qemu-devel] [PATCH v3 11/15] console: ignore ui_info updates which don't actually update something Stefan Hajnoczi
2016-06-13 17:05 ` Stefan Hajnoczi [this message]
2016-06-13 17:05 ` [Qemu-devel] [PATCH v3 13/15] blockjob: add pause points Stefan Hajnoczi
2016-06-13 17:05 ` [Qemu-devel] [PATCH v3 14/15] blockjob: add AioContext attach/detach callbacks Stefan Hajnoczi
2016-06-13 17:05 ` [Qemu-devel] [PATCH v3 15/15] mirror: follow AioContext change gracefully Stefan Hajnoczi
2016-06-14 12:09   ` Paolo Bonzini
2016-06-14 12:47     ` Stefan Hajnoczi
2016-06-13 17:16 ` [Qemu-devel] [PATCH v3 00/15] " Stefan Hajnoczi
2016-06-14 13:16 ` Fam Zheng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1465837535-30067-13-git-send-email-stefanha@redhat.com \
    --to=stefanha@redhat.com \
    --cc=famz@redhat.com \
    --cc=jcody@redhat.com \
    --cc=jjherne@linux.vnet.ibm.com \
    --cc=kwolf@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).