qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Hajnoczi <stefanha@redhat.com>
To: qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>,
	jjherne@linux.vnet.ibm.com, Fam Zheng <famz@redhat.com>,
	Paolo Bonzini <pbonzini@redhat.com>, Jeff Cody <jcody@redhat.com>,
	mreitz@redhat.com, Peter Maydell <peter.maydell@linaro.org>
Subject: [Qemu-devel] [PATCH v3 05/15] target-i386: Add comment about do_interrupt_user() next_eip argument
Date: Mon, 13 Jun 2016 18:05:25 +0100	[thread overview]
Message-ID: <1465837535-30067-6-git-send-email-stefanha@redhat.com> (raw)
In-Reply-To: <1465837535-30067-1-git-send-email-stefanha@redhat.com>

From: Peter Maydell <peter.maydell@linaro.org>

Add a comment to do_interrupt_user() along the same lines as the
existing one for do_interrupt_all() noting that the next_eip
argument is not used unless is_int is true or intno is EXCP_SYSCALL.

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Sergey Fedorov <sergey.fedorov@linaro.org>
Acked-by: Eduardo Habkost <ehabkost@redhat.com>
Acked-by: Riku Voipio <riku.voipio@linaro.org>
Message-id: 1463494687-25947-6-git-send-email-peter.maydell@linaro.org
---
 target-i386/seg_helper.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/target-i386/seg_helper.c b/target-i386/seg_helper.c
index 97aee09..6cbdf17 100644
--- a/target-i386/seg_helper.c
+++ b/target-i386/seg_helper.c
@@ -1129,7 +1129,11 @@ static void do_interrupt_real(CPUX86State *env, int intno, int is_int,
 }
 
 #if defined(CONFIG_USER_ONLY)
-/* fake user mode interrupt */
+/* fake user mode interrupt. is_int is TRUE if coming from the int
+ * instruction. next_eip is the env->eip value AFTER the interrupt
+ * instruction. It is only relevant if is_int is TRUE or if intno
+ * is EXCP_SYSCALL.
+ */
 static void do_interrupt_user(CPUX86State *env, int intno, int is_int,
                               int error_code, target_ulong next_eip)
 {
-- 
2.5.5

  parent reply	other threads:[~2016-06-13 17:05 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-13 17:05 [Qemu-devel] [PATCH v3 00/15] mirror: follow AioContext change gracefully Stefan Hajnoczi
2016-06-13 17:05 ` [Qemu-devel] [PATCH v3 01/15] translate-all.c: Don't pass puc, locked to tb_invalidate_phys_page() Stefan Hajnoczi
2016-06-13 17:05 ` [Qemu-devel] [PATCH v3 02/15] user-exec: Push resume-from-signal code out to handle_cpu_signal() Stefan Hajnoczi
2016-06-13 17:05 ` [Qemu-devel] [PATCH v3 03/15] cpu-exec: Rename cpu_resume_from_signal() to cpu_loop_exit_noexc() Stefan Hajnoczi
2016-06-13 17:05 ` [Qemu-devel] [PATCH v3 04/15] user-exec: Don't reextract sigmask from usercontext pointer Stefan Hajnoczi
2016-06-13 17:05 ` Stefan Hajnoczi [this message]
2016-06-13 17:05 ` [Qemu-devel] [PATCH v3 06/15] target-i386: Move user-mode exception actions out of user-exec.c Stefan Hajnoczi
2016-06-13 17:05 ` [Qemu-devel] [PATCH v3 07/15] vnc: drop unused depth arg for set_pixel_format Stefan Hajnoczi
2016-06-13 17:05 ` [Qemu-devel] [PATCH v3 08/15] ui: fix regression in printing VNC host/port on startup Stefan Hajnoczi
2016-06-13 17:05 ` [Qemu-devel] [PATCH v3 09/15] gtk: fix vte version check Stefan Hajnoczi
2016-06-13 17:05 ` [Qemu-devel] [PATCH v3 10/15] ui/console-gl: Add support for big endian display surfaces Stefan Hajnoczi
2016-06-13 17:05 ` [Qemu-devel] [PATCH v3 11/15] console: ignore ui_info updates which don't actually update something Stefan Hajnoczi
2016-06-13 17:05 ` [Qemu-devel] [PATCH v3 12/15] blockjob: move iostatus reset out of block_job_enter() Stefan Hajnoczi
2016-06-13 17:05 ` [Qemu-devel] [PATCH v3 13/15] blockjob: add pause points Stefan Hajnoczi
2016-06-13 17:05 ` [Qemu-devel] [PATCH v3 14/15] blockjob: add AioContext attach/detach callbacks Stefan Hajnoczi
2016-06-13 17:05 ` [Qemu-devel] [PATCH v3 15/15] mirror: follow AioContext change gracefully Stefan Hajnoczi
2016-06-14 12:09   ` Paolo Bonzini
2016-06-14 12:47     ` Stefan Hajnoczi
2016-06-13 17:16 ` [Qemu-devel] [PATCH v3 00/15] " Stefan Hajnoczi
2016-06-14 13:16 ` Fam Zheng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1465837535-30067-6-git-send-email-stefanha@redhat.com \
    --to=stefanha@redhat.com \
    --cc=famz@redhat.com \
    --cc=jcody@redhat.com \
    --cc=jjherne@linux.vnet.ibm.com \
    --cc=kwolf@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).