* [Qemu-devel] [PATCH] qemu-img bench: Fix uninitialised writethrough mode
@ 2016-06-14 9:33 Kevin Wolf
2016-06-14 13:35 ` [Qemu-devel] [Qemu-block] " Max Reitz
2016-06-16 9:54 ` Stefan Hajnoczi
0 siblings, 2 replies; 3+ messages in thread
From: Kevin Wolf @ 2016-06-14 9:33 UTC (permalink / raw)
To: qemu-block; +Cc: kwolf, qemu-devel
If no -t option is specified, bool writethrough stayed uninitialised.
Initialise it as false, which makes cache=writeback the default cache
mode.
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
---
qemu-img.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/qemu-img.c b/qemu-img.c
index 251386b..14e2661 100644
--- a/qemu-img.c
+++ b/qemu-img.c
@@ -3570,7 +3570,7 @@ static int img_bench(int argc, char **argv)
BlockBackend *blk = NULL;
BenchData data = {};
int flags = 0;
- bool writethrough;
+ bool writethrough = false;
struct timeval t1, t2;
int i;
--
1.8.3.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [Qemu-block] [PATCH] qemu-img bench: Fix uninitialised writethrough mode
2016-06-14 9:33 [Qemu-devel] [PATCH] qemu-img bench: Fix uninitialised writethrough mode Kevin Wolf
@ 2016-06-14 13:35 ` Max Reitz
2016-06-16 9:54 ` Stefan Hajnoczi
1 sibling, 0 replies; 3+ messages in thread
From: Max Reitz @ 2016-06-14 13:35 UTC (permalink / raw)
To: Kevin Wolf, qemu-block; +Cc: qemu-devel
[-- Attachment #1: Type: text/plain, Size: 374 bytes --]
On 14.06.2016 11:33, Kevin Wolf wrote:
> If no -t option is specified, bool writethrough stayed uninitialised.
> Initialise it as false, which makes cache=writeback the default cache
> mode.
>
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
> qemu-img.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Max Reitz <mreitz@redhat.com>
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [Qemu-block] [PATCH] qemu-img bench: Fix uninitialised writethrough mode
2016-06-14 9:33 [Qemu-devel] [PATCH] qemu-img bench: Fix uninitialised writethrough mode Kevin Wolf
2016-06-14 13:35 ` [Qemu-devel] [Qemu-block] " Max Reitz
@ 2016-06-16 9:54 ` Stefan Hajnoczi
1 sibling, 0 replies; 3+ messages in thread
From: Stefan Hajnoczi @ 2016-06-16 9:54 UTC (permalink / raw)
To: Kevin Wolf; +Cc: qemu-block, qemu-devel
[-- Attachment #1: Type: text/plain, Size: 401 bytes --]
On Tue, Jun 14, 2016 at 11:33:25AM +0200, Kevin Wolf wrote:
> If no -t option is specified, bool writethrough stayed uninitialised.
> Initialise it as false, which makes cache=writeback the default cache
> mode.
>
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
> qemu-img.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-06-16 9:54 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-06-14 9:33 [Qemu-devel] [PATCH] qemu-img bench: Fix uninitialised writethrough mode Kevin Wolf
2016-06-14 13:35 ` [Qemu-devel] [Qemu-block] " Max Reitz
2016-06-16 9:54 ` Stefan Hajnoczi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).