* [Qemu-devel] [PATCH] linux-user: add missing return in netlink switch statement
@ 2016-06-14 13:07 Laurent Vivier
2016-06-14 13:14 ` Peter Maydell
0 siblings, 1 reply; 2+ messages in thread
From: Laurent Vivier @ 2016-06-14 13:07 UTC (permalink / raw)
To: Riku Voipio; +Cc: Peter Maydell, qemu-devel, Laurent Vivier
Reported-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
---
linux-user/syscall.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/linux-user/syscall.c b/linux-user/syscall.c
index 71ccbd9..0b937ca 100644
--- a/linux-user/syscall.c
+++ b/linux-user/syscall.c
@@ -1688,6 +1688,7 @@ static abi_long target_to_host_for_each_nlmsg(struct nlmsghdr *nlh,
struct nlmsgerr *e = NLMSG_DATA(nlh);
e->error = tswap32(e->error);
tswap_nlmsghdr(&e->msg);
+ return 0;
}
default:
ret = target_to_host_nlmsg(nlh);
--
2.5.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Qemu-devel] [PATCH] linux-user: add missing return in netlink switch statement
2016-06-14 13:07 [Qemu-devel] [PATCH] linux-user: add missing return in netlink switch statement Laurent Vivier
@ 2016-06-14 13:14 ` Peter Maydell
0 siblings, 0 replies; 2+ messages in thread
From: Peter Maydell @ 2016-06-14 13:14 UTC (permalink / raw)
To: Laurent Vivier; +Cc: Riku Voipio, QEMU Developers
On 14 June 2016 at 14:07, Laurent Vivier <laurent@vivier.eu> wrote:
> Reported-by: Peter Maydell <peter.maydell@linaro.org>
> Signed-off-by: Laurent Vivier <laurent@vivier.eu>
> ---
> linux-user/syscall.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/linux-user/syscall.c b/linux-user/syscall.c
> index 71ccbd9..0b937ca 100644
> --- a/linux-user/syscall.c
> +++ b/linux-user/syscall.c
> @@ -1688,6 +1688,7 @@ static abi_long target_to_host_for_each_nlmsg(struct nlmsghdr *nlh,
> struct nlmsgerr *e = NLMSG_DATA(nlh);
> e->error = tswap32(e->error);
> tswap_nlmsghdr(&e->msg);
> + return 0;
> }
> default:
> ret = target_to_host_nlmsg(nlh);
> --
> 2.5.5
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
thanks
-- PMM
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-06-14 13:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-06-14 13:07 [Qemu-devel] [PATCH] linux-user: add missing return in netlink switch statement Laurent Vivier
2016-06-14 13:14 ` Peter Maydell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).