From: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
To: qemu-devel@nongnu.org
Cc: den@openvz.org, vsementsov@virtuozzo.com, kwolf@redhat.com,
mreitz@redhat.com
Subject: [Qemu-devel] [PATCH v2 0/2] block: fix libvirt snapshot with existing bitmaps
Date: Tue, 14 Jun 2016 20:08:11 +0300 [thread overview]
Message-ID: <1465924093-76875-1-git-send-email-vsementsov@virtuozzo.com> (raw)
v2:
- additional patch with asserts for hbitmap. As BdrvDirtyBitmap is only
an interlayer here, I decided to plase asserts into HBitmap public
functions.
- add comment
- from Max's comments:
- assert after if block
- bitmap->size instead of bdrv_nb_sectors. It is not beautiful, but
with bdrv_nb_sectors we have to handle error code here, which
would be worse I think.
Vladimir Sementsov-Ogievskiy (2):
hbitmap: add 'pos < size' asserts
block: fix libvirt snapshot with existing bitmaps
block/dirty-bitmap.c | 14 ++++++++++++++
util/hbitmap.c | 3 +++
2 files changed, 17 insertions(+)
--
1.8.3.1
next reply other threads:[~2016-06-14 17:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-14 17:08 Vladimir Sementsov-Ogievskiy [this message]
2016-06-14 17:08 ` [Qemu-devel] [PATCH 1/2] hbitmap: add 'pos < size' asserts Vladimir Sementsov-Ogievskiy
2016-06-14 17:08 ` [Qemu-devel] [PATCH 2/2] block: fix libvirt snapshot with existing bitmaps Vladimir Sementsov-Ogievskiy
2016-06-14 21:33 ` Eric Blake
2016-06-15 13:08 ` Vladimir Sementsov-Ogievskiy
2016-06-15 15:29 ` Max Reitz
2016-06-14 18:09 ` [Qemu-devel] [PATCH v2 0/2] " Max Reitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1465924093-76875-1-git-send-email-vsementsov@virtuozzo.com \
--to=vsementsov@virtuozzo.com \
--cc=den@openvz.org \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).