From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57463) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bDEbA-0006ix-R7 for qemu-devel@nongnu.org; Wed, 15 Jun 2016 13:27:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bDEb3-0007To-Ly for qemu-devel@nongnu.org; Wed, 15 Jun 2016 13:27:27 -0400 Received: from mx1.redhat.com ([209.132.183.28]:52731) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bDEb3-0007TM-G8 for qemu-devel@nongnu.org; Wed, 15 Jun 2016 13:27:21 -0400 From: Markus Armbruster Date: Wed, 15 Jun 2016 19:27:14 +0200 Message-Id: <1466011636-6112-2-git-send-email-armbru@redhat.com> In-Reply-To: <1466011636-6112-1-git-send-email-armbru@redhat.com> References: <1466011636-6112-1-git-send-email-armbru@redhat.com> Subject: [Qemu-devel] [PATCH 1/3] log: Plug memory leak on multiple -dfilter List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: alex.bennee@linaro.org, pbonzini@redhat.com -dfilter overwrites any previous filter. The overwritten filter is leaked. Leaks since the beginning (commit 3514552, v2.6.0). Free it properly. Signed-off-by: Markus Armbruster --- util/log.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/util/log.c b/util/log.c index 5ad72c1..6f45e0a 100644 --- a/util/log.c +++ b/util/log.c @@ -145,9 +145,16 @@ bool qemu_log_in_addr_range(uint64_t addr) void qemu_set_dfilter_ranges(const char *filter_spec) { gchar **ranges = g_strsplit(filter_spec, ",", 0); + + if (debug_regions) { + g_array_unref(debug_regions); + debug_regions = NULL; + } + if (ranges) { gchar **next = ranges; gchar *r = *next++; + debug_regions = g_array_sized_new(FALSE, FALSE, sizeof(Range), g_strv_length(ranges)); while (r) { -- 2.5.5