From: Colin Lord <clord@redhat.com>
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com, qemu-block@nongnu.org, mreitz@redhat.com,
Colin Lord <clord@redhat.com>
Subject: [Qemu-devel] [PATCH 0/2] Dynamic module loading for block drivers
Date: Wed, 15 Jun 2016 14:40:53 -0400 [thread overview]
Message-ID: <1466016055-31351-1-git-send-email-clord@redhat.com> (raw)
This is a repost of some previous patches written by Marc Marí which
were also reposted by Richard Jones a few months ago. The original
series and reposted series are here:
https://lists.gnu.org/archive/html/qemu-devel/2015-09/msg01995.html
https://lists.nongnu.org/archive/html/qemu-devel/2016-04/msg01994.html
I've tried to take some of the previous feedback and integrate it into
this series. There are also a few things I haven't touched that were
previously mentioned though:
1) Denis Lunev suggested having block_module_load_one return the
loaded driver to reduce duplicated for loops in many of the functions
in block.c. I'd be happy to do this but wasn't completely sure how
error handling would happen in that case since currently the return
value is an integer error code. Would I switch to using the
error handling mechanisms provided in util/error.c?
2) In the past some debate was had about the design of the modules.
I haven't made any changes in this regard because it didn't seem a
conclusion had been reached. Some links for background:
Fam Zheng suggested a simpler parser:
https://lists.gnu.org/archive/html/qemu-devel/2015-09/msg02201.html
Denis Lunev suggested a design more similar to Linux kernel modules:
https://lists.gnu.org/archive/html/qemu-devel/2015-09/msg05331.html
Richard Jones suggested reasons to keep things as is:
https://lists.nongnu.org/archive/html/qemu-devel/2016-04/msg01994.html
Marc Mari (2):
blockdev: Add dynamic generation of module_block.h
blockdev: Add dynamic module loading for block drivers
.gitignore | 1 +
Makefile | 11 +++-
block.c | 86 +++++++++++++++++++++++---
include/qemu/module.h | 3 +
scripts/modules/module_block.py | 134 ++++++++++++++++++++++++++++++++++++++++
util/module.c | 37 +++--------
6 files changed, 233 insertions(+), 39 deletions(-)
create mode 100644 scripts/modules/module_block.py
--
2.5.5
next reply other threads:[~2016-06-15 18:41 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-15 18:40 Colin Lord [this message]
2016-06-15 18:40 ` [Qemu-devel] [PATCH 1/2] blockdev: Add dynamic generation of module_block.h Colin Lord
2016-06-15 22:48 ` Paolo Bonzini
2016-06-16 4:59 ` Fam Zheng
2016-06-16 13:57 ` Colin Lord
2016-06-17 9:57 ` [Qemu-devel] [Qemu-block] " Stefan Hajnoczi
2016-06-15 18:40 ` [Qemu-devel] [PATCH 2/2] blockdev: Add dynamic module loading for block drivers Colin Lord
2016-06-15 22:50 ` Paolo Bonzini
2016-06-16 14:00 ` Colin Lord
2016-06-16 14:05 ` Paolo Bonzini
2016-06-16 14:10 ` Colin Lord
2016-06-16 14:12 ` Paolo Bonzini
2016-06-17 9:54 ` [Qemu-devel] [Qemu-block] [PATCH 0/2] Dynamic " Stefan Hajnoczi
2016-06-20 15:32 ` Colin Lord
2016-06-21 9:32 ` Stefan Hajnoczi
2016-06-21 10:01 ` [Qemu-devel] " Paolo Bonzini
2016-06-21 15:42 ` [Qemu-devel] [Qemu-block] " Colin Lord
2016-06-21 16:59 ` [Qemu-devel] " Paolo Bonzini
2016-06-22 10:09 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1466016055-31351-1-git-send-email-clord@redhat.com \
--to=clord@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).