From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53047) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bDHUy-0008U0-5o for qemu-devel@nongnu.org; Wed, 15 Jun 2016 16:33:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bDHUs-0005ku-IH for qemu-devel@nongnu.org; Wed, 15 Jun 2016 16:33:15 -0400 Received: from mx1.redhat.com ([209.132.183.28]:50144) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bDHUs-0005kp-DC for qemu-devel@nongnu.org; Wed, 15 Jun 2016 16:33:10 -0400 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 0DDD165418 for ; Wed, 15 Jun 2016 20:33:10 +0000 (UTC) From: Eduardo Habkost Date: Wed, 15 Jun 2016 17:32:47 -0300 Message-Id: <1466022773-8965-5-git-send-email-ehabkost@redhat.com> In-Reply-To: <1466022773-8965-1-git-send-email-ehabkost@redhat.com> References: <1466022773-8965-1-git-send-email-ehabkost@redhat.com> Subject: [Qemu-devel] [PATCH 04/10] qdev: Use error_prepend() for errors applying globals List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org, Markus Armbruster Cc: Paolo Bonzini , Marcel Apfelbaum , Igor Mammedov The same Error* will be used in an error_propagate() call in the future, so prepend a "can't apply global" prefix to it. Signed-off-by: Eduardo Habkost --- hw/core/qdev-properties.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/hw/core/qdev-properties.c b/hw/core/qdev-properties.c index 64e17aa..cd19603 100644 --- a/hw/core/qdev-properties.c +++ b/hw/core/qdev-properties.c @@ -1079,8 +1079,9 @@ static void qdev_prop_set_globals_for_type(DeviceState *dev, object_property_parse(OBJECT(dev), prop->value, prop->property, &err); if (err != NULL) { assert(prop->user_provided); - error_reportf_err(err, "Warning: global %s.%s=%s ignored: ", - prop->driver, prop->property, prop->value); + error_prepend(&err, "can't apply global %s.%s=%s: ", + prop->driver, prop->property, prop->value); + error_reportf_err(err, "Warning: "); } } } -- 2.5.5