qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Eduardo Habkost <ehabkost@redhat.com>
To: qemu-devel@nongnu.org, Markus Armbruster <armbru@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
	Marcel Apfelbaum <marcel@redhat.com>,
	Igor Mammedov <imammedo@redhat.com>
Subject: [Qemu-devel] [PATCH 06/10] machine: Add machine_register_compat_props() function
Date: Wed, 15 Jun 2016 17:32:49 -0300	[thread overview]
Message-ID: <1466022773-8965-7-git-send-email-ehabkost@redhat.com> (raw)
In-Reply-To: <1466022773-8965-1-git-send-email-ehabkost@redhat.com>

Move the compat_props handling to core machine code.

Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
---
 hw/core/machine.c   | 16 ++++++++++++++++
 include/hw/boards.h |  1 +
 vl.c                |  9 ++-------
 3 files changed, 19 insertions(+), 7 deletions(-)

diff --git a/hw/core/machine.c b/hw/core/machine.c
index ccdd5fa..754a054 100644
--- a/hw/core/machine.c
+++ b/hw/core/machine.c
@@ -580,6 +580,22 @@ static void machine_class_finalize(ObjectClass *klass, void *data)
     }
 }
 
+void machine_register_compat_props(MachineState *machine)
+{
+    MachineClass *mc = MACHINE_GET_CLASS(machine);
+    int i;
+    GlobalProperty *p;
+
+    if (!mc->compat_props) {
+        return;
+    }
+
+    for (i = 0; i < mc->compat_props->len; i++) {
+        p = g_array_index(mc->compat_props, GlobalProperty *, i);
+        qdev_prop_register_global(p);
+    }
+}
+
 static const TypeInfo machine_info = {
     .name = TYPE_MACHINE,
     .parent = TYPE_OBJECT,
diff --git a/include/hw/boards.h b/include/hw/boards.h
index d268bd0..ee71dc0 100644
--- a/include/hw/boards.h
+++ b/include/hw/boards.h
@@ -40,6 +40,7 @@ int machine_kvm_shadow_mem(MachineState *machine);
 int machine_phandle_start(MachineState *machine);
 bool machine_dump_guest_core(MachineState *machine);
 bool machine_mem_merge(MachineState *machine);
+void machine_register_compat_props(MachineState *machine);
 
 /**
  * CPUArchId:
diff --git a/vl.c b/vl.c
index d88ddba..86d53ca 100644
--- a/vl.c
+++ b/vl.c
@@ -4483,13 +4483,8 @@ int main(int argc, char **argv, char **envp)
             exit (i == 1 ? 1 : 0);
     }
 
-    if (machine_class->compat_props) {
-        GlobalProperty *p;
-        for (i = 0; i < machine_class->compat_props->len; i++) {
-            p = g_array_index(machine_class->compat_props, GlobalProperty *, i);
-            qdev_prop_register_global(p);
-        }
-    }
+    machine_register_compat_props(current_machine);
+
     qemu_opts_foreach(qemu_find_opts("global"),
                       global_init_func, NULL, &err);
     if (err) {
-- 
2.5.5

  parent reply	other threads:[~2016-06-15 20:33 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-15 20:32 [Qemu-devel] [PATCH 00/10] globals: Clean up validation and error checking Eduardo Habkost
2016-06-15 20:32 ` [Qemu-devel] [PATCH 01/10] qdev: Don't stop applying globals on first error Eduardo Habkost
2016-06-19 16:40   ` Marcel Apfelbaum
2016-06-20  7:43   ` Markus Armbruster
2016-06-15 20:32 ` [Qemu-devel] [PATCH 02/10] qdev: Eliminate qemu_add_globals() function Eduardo Habkost
2016-06-20 12:03   ` Igor Mammedov
2016-06-15 20:32 ` [Qemu-devel] [PATCH 03/10] vl: Reject invalid class names on -global Eduardo Habkost
2016-06-20  7:56   ` Markus Armbruster
2016-06-20 12:44   ` Igor Mammedov
2016-06-15 20:32 ` [Qemu-devel] [PATCH 04/10] qdev: Use error_prepend() for errors applying globals Eduardo Habkost
2016-06-20  8:02   ` Markus Armbruster
2016-06-20 13:43     ` Eduardo Habkost
2016-06-15 20:32 ` [Qemu-devel] [PATCH 05/10] qdev: GlobalProperty.errp field Eduardo Habkost
2016-06-20  8:14   ` Markus Armbruster
2016-06-20 13:45     ` Eduardo Habkost
2016-06-15 20:32 ` Eduardo Habkost [this message]
2016-06-19 16:25   ` [Qemu-devel] [PATCH 06/10] machine: Add machine_register_compat_props() function Marcel Apfelbaum
2016-06-15 20:32 ` [Qemu-devel] [PATCH 07/10] vl: Set errp to &error_abort on machine compat_props Eduardo Habkost
2016-06-19 16:27   ` Marcel Apfelbaum
2016-06-15 20:32 ` [Qemu-devel] [PATCH 08/10] qdev: Eliminate "global not used" warning Eduardo Habkost
2016-06-15 20:32 ` [Qemu-devel] [PATCH 09/10] qdev: Eliminate GlobalProperty 'used' and 'user_provided' fields Eduardo Habkost
2016-06-15 20:32 ` [Qemu-devel] [PATCH 10/10] machine: Skip global registration for non-existing classes Eduardo Habkost
2016-06-19 16:39   ` Marcel Apfelbaum
2016-06-19 16:50     ` Marcel Apfelbaum
2016-06-20 13:38       ` Eduardo Habkost
2016-06-20 13:11 ` [Qemu-devel] [PATCH 00/10] globals: Clean up validation and error checking Igor Mammedov
2016-06-20 13:48   ` Eduardo Habkost

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1466022773-8965-7-git-send-email-ehabkost@redhat.com \
    --to=ehabkost@redhat.com \
    --cc=armbru@redhat.com \
    --cc=imammedo@redhat.com \
    --cc=marcel@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).