From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:48119)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1bDSsI-0007sD-Ok
	for qemu-devel@nongnu.org; Thu, 16 Jun 2016 04:42:07 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1bDSsC-0001Lf-Ow
	for qemu-devel@nongnu.org; Thu, 16 Jun 2016 04:42:05 -0400
Received: from mx1.redhat.com ([209.132.183.28]:60820)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1bDSsC-0001Lb-Ix
	for qemu-devel@nongnu.org; Thu, 16 Jun 2016 04:42:00 -0400
Message-ID: <1466066518.7715.19.camel@redhat.com>
From: Gerd Hoffmann <kraxel@redhat.com>
Date: Thu, 16 Jun 2016 10:41:58 +0200
In-Reply-To: <CAFEAcA_bPkpmb38Wqiiaer7HYOE5i7AqyfbgpLgDsVqay30Ouw@mail.gmail.com>
References: <1466064474-26229-1-git-send-email-kraxel@redhat.com>
	<1466064474-26229-3-git-send-email-kraxel@redhat.com>
	<CAFEAcA_bPkpmb38Wqiiaer7HYOE5i7AqyfbgpLgDsVqay30Ouw@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Mime-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 2/2] msmouse: send short messages if
 possible.
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: QEMU Developers <qemu-devel@nongnu.org>, Paolo Bonzini <pbonzini@redhat.com>, Anatoly Gusev <avg.tolik@gmail.com>

  Hi,

> > -    if (mouse->outlen <=3D sizeof(mouse->outbuf) - 4) {
> > +    if (mouse->outlen <=3D sizeof(mouse->outbuf) - count) {
> >          /* We always send the packet of, so that we do not have to kee=
p track
> >             of previous state of the middle button. This can potentiall=
y confuse
> >             some very old drivers for two button mice though. */
>=20
> Is this comment now out of date ?

Yes.  I'll drop it in v2.=20

cheers,
  Gerd