* [Qemu-devel] [PATCH] vl: remove unnecessary duplicate call to tpm_cleanup
@ 2016-06-16 12:25 Paolo Bonzini
2016-07-26 12:30 ` Michael Tokarev
0 siblings, 1 reply; 2+ messages in thread
From: Paolo Bonzini @ 2016-06-16 12:25 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial, stefanb
tpm_cleanup is called from main() and also registered with atexit from
tpm_init. The function only visits the tpm_backends linked list, and the
atexit registration happens right after tpm_init fills in the list from
-tpmdev options. Therefore, the direct call is unnecessary. Remove it.
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
vl.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/vl.c b/vl.c
index a7cb3b3..e05ded4 100644
--- a/vl.c
+++ b/vl.c
@@ -4631,9 +4631,6 @@ int main(int argc, char **argv, char **envp)
bdrv_close_all();
pause_all_vcpus();
res_free();
-#ifdef CONFIG_TPM
- tpm_cleanup();
-#endif
return 0;
}
--
2.5.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Qemu-devel] [PATCH] vl: remove unnecessary duplicate call to tpm_cleanup
2016-06-16 12:25 [Qemu-devel] [PATCH] vl: remove unnecessary duplicate call to tpm_cleanup Paolo Bonzini
@ 2016-07-26 12:30 ` Michael Tokarev
0 siblings, 0 replies; 2+ messages in thread
From: Michael Tokarev @ 2016-07-26 12:30 UTC (permalink / raw)
To: Paolo Bonzini, qemu-devel; +Cc: qemu-trivial, stefanb
16.06.2016 15:25, Paolo Bonzini wrote:
> tpm_cleanup is called from main() and also registered with atexit from
> tpm_init. The function only visits the tpm_backends linked list, and the
> atexit registration happens right after tpm_init fills in the list from
> -tpmdev options. Therefore, the direct call is unnecessary. Remove it.
Applied to -trivial. thanks!
/mjt
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-07-26 12:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-06-16 12:25 [Qemu-devel] [PATCH] vl: remove unnecessary duplicate call to tpm_cleanup Paolo Bonzini
2016-07-26 12:30 ` Michael Tokarev
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).