From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53196) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bDZrm-00046o-Bp for qemu-devel@nongnu.org; Thu, 16 Jun 2016 12:10:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bDZrj-0007jQ-45 for qemu-devel@nongnu.org; Thu, 16 Jun 2016 12:10:02 -0400 Received: from mailhub.sw.ru ([195.214.232.25]:28424 helo=relay.sw.ru) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bDZri-0007iG-Mv for qemu-devel@nongnu.org; Thu, 16 Jun 2016 12:09:59 -0400 From: "Denis V. Lunev" Date: Thu, 16 Jun 2016 19:09:41 +0300 Message-Id: <1466093381-6120-4-git-send-email-den@openvz.org> In-Reply-To: <1466093381-6120-1-git-send-email-den@openvz.org> References: <1466093381-6120-1-git-send-email-den@openvz.org> Subject: [Qemu-devel] [PATCH 3/3] block: process before_write_notifiers in bdrv_co_discard List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org, qemu-block@nongnu.org Cc: den@openvz.org, Fam Zheng , Stefan Hajnoczi , Kevin Wolf , Max Reitz This is mandatory for correct backup creation. In the other case the content under this area would be lost. Dirty bits are set exactly like in bdrv_aligned_pwritev, i.e. they are set even if notifier has returned a error. Signed-off-by: Denis V. Lunev Reviewed-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Fam Zheng CC: Fam Zheng CC: Stefan Hajnoczi CC: Kevin Wolf CC: Max Reitz --- block/io.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/block/io.c b/block/io.c index 11fcfcb..2177cc6 100644 --- a/block/io.c +++ b/block/io.c @@ -2264,6 +2264,11 @@ int coroutine_fn bdrv_co_discard(BlockDriverState *bs, int64_t sector_num, tracked_request_begin(&req, bs, sector_num << BDRV_SECTOR_BITS, nb_sectors << BDRV_SECTOR_BITS, BDRV_TRACKED_DISCARD); + ret = notifier_with_return_list_notify(&bs->before_write_notifiers, &req); + if (ret < 0) { + goto out; + } + max_discard = MIN_NON_ZERO(bs->bl.max_discard, BDRV_REQUEST_MAX_SECTORS); while (nb_sectors > 0) { int ret; -- 2.1.4