qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: David Gibson <david@gibson.dropbear.id.au>
To: peter.maydell@linaro.org
Cc: agraf@suse.de, aik@ozlabs.ru, bharata@linux.vnet.ibm.com,
	imammedo@redhat.com, mdroth@linux.vnet.ibm.com,
	qemu-ppc@nongnu.org, qemu-devel@nongnu.org,
	Jakub Horak <thement@ibawizard.net>,
	David Gibson <david@gibson.dropbear.id.au>
Subject: [Qemu-devel] [PULL 03/18] target-ppc: Bug in BookE wait instruction
Date: Fri, 17 Jun 2016 16:36:24 +1000	[thread overview]
Message-ID: <1466145399-32209-4-git-send-email-david@gibson.dropbear.id.au> (raw)
In-Reply-To: <1466145399-32209-1-git-send-email-david@gibson.dropbear.id.au>

From: Jakub Horak <thement@ibawizard.net>

Fixed bug in code generation for the PowerPC "wait" instruction. It
doesn't make sense to store a non-initialized register.

Signed-off-by: Jakub Horak <thement@ibawizard.net>
[dwg: revised commit message]
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
---
 target-ppc/translate.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/target-ppc/translate.c b/target-ppc/translate.c
index b689475..1f401b7 100644
--- a/target-ppc/translate.c
+++ b/target-ppc/translate.c
@@ -3499,7 +3499,7 @@ static void gen_sync(DisasContext *ctx)
 /* wait */
 static void gen_wait(DisasContext *ctx)
 {
-    TCGv_i32 t0 = tcg_temp_new_i32();
+    TCGv_i32 t0 = tcg_const_i32(1);
     tcg_gen_st_i32(t0, cpu_env,
                    -offsetof(PowerPCCPU, env) + offsetof(CPUState, halted));
     tcg_temp_free_i32(t0);
-- 
2.5.5

  parent reply	other threads:[~2016-06-17  6:35 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-17  6:36 [Qemu-devel] [PULL 00/18] ppc-for-2.7 queue 20160617 David Gibson
2016-06-17  6:36 ` [Qemu-devel] [PULL 01/18] hw/ppc/spapr: Silence deprecation message in qtest mode David Gibson
2016-06-17  6:36 ` [Qemu-devel] [PULL 02/18] ppc / sparc: Add a tester for checking whether OpenBIOS runs successfully David Gibson
2016-06-17 13:13   ` Thomas Huth
2016-06-17  6:36 ` David Gibson [this message]
2016-06-17  6:36 ` [Qemu-devel] [PULL 04/18] vfio: Fix broken EEH David Gibson
2016-06-17  6:36 ` [Qemu-devel] [PULL 05/18] target-ppc: Fix rlwimi, rlwinm, rlwnm David Gibson
2016-06-17  6:36 ` [Qemu-devel] [PULL 06/18] qdev: hotplug: Introduce HotplugHandler.pre_plug() callback David Gibson
2016-06-17  6:36 ` [Qemu-devel] [PULL 07/18] cpu: Abstract CPU core type David Gibson
2016-06-17  6:36 ` [Qemu-devel] [PULL 08/18] xics, xics_kvm: Handle CPU unplug correctly David Gibson
2016-06-17  6:36 ` [Qemu-devel] [PULL 09/18] spapr_drc: Prevent detach racing against attach for CPU DR David Gibson
2016-06-17  6:36 ` [Qemu-devel] [PULL 10/18] qom: API to get instance_size of a type David Gibson
2016-06-17  6:36 ` [Qemu-devel] [PULL 11/18] spapr: Abstract CPU core device and type specific core devices David Gibson
2016-06-17  6:36 ` [Qemu-devel] [PULL 12/18] spapr: Move spapr_cpu_init() to spapr_cpu_core.c David Gibson
2016-06-17  6:36 ` [Qemu-devel] [PULL 13/18] spapr: convert boot CPUs into CPU core devices David Gibson
2016-06-17  6:36 ` [Qemu-devel] [PULL 14/18] spapr: CPU hotplug support David Gibson
2016-06-17  6:36 ` [Qemu-devel] [PULL 15/18] spapr: CPU hot unplug support David Gibson
2017-01-26 11:32   ` Igor Mammedov
2017-01-26 14:26     ` Bharata B Rao
2017-01-30 11:53       ` Igor Mammedov
2016-06-17  6:36 ` [Qemu-devel] [PULL 16/18] QMP: Add query-hotpluggable-cpus David Gibson
2016-06-17  6:36 ` [Qemu-devel] [PULL 17/18] hmp: Add 'info hotpluggable-cpus' HMP command David Gibson
2016-06-17  6:36 ` [Qemu-devel] [PULL 18/18] spapr: implement query-hotpluggable-cpus callback David Gibson
2016-06-17 12:35 ` [Qemu-devel] [PULL 00/18] ppc-for-2.7 queue 20160617 Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1466145399-32209-4-git-send-email-david@gibson.dropbear.id.au \
    --to=david@gibson.dropbear.id.au \
    --cc=agraf@suse.de \
    --cc=aik@ozlabs.ru \
    --cc=bharata@linux.vnet.ibm.com \
    --cc=imammedo@redhat.com \
    --cc=mdroth@linux.vnet.ibm.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    --cc=thement@ibawizard.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).