From: Xiao Guangrong <guangrong.xiao@linux.intel.com>
To: mst@redhat.com
Cc: kvm@vger.kernel.org, qemu-devel@nongnu.org,
Xiao Guangrong <guangrong.xiao@linux.intel.com>
Subject: [Qemu-devel] [PATCH v5 09/13] nvdimm acpi: check revision
Date: Fri, 17 Jun 2016 19:08:12 +0800 [thread overview]
Message-ID: <1466161696-99298-10-git-send-email-guangrong.xiao@linux.intel.com> (raw)
In-Reply-To: <1466161696-99298-1-git-send-email-guangrong.xiao@linux.intel.com>
Currently only revision 1 is supported
Signed-off-by: Xiao Guangrong <guangrong.xiao@linux.intel.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
hw/acpi/nvdimm.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/hw/acpi/nvdimm.c b/hw/acpi/nvdimm.c
index 07c95c1..8b89285 100644
--- a/hw/acpi/nvdimm.c
+++ b/hw/acpi/nvdimm.c
@@ -485,6 +485,13 @@ nvdimm_dsm_write(void *opaque, hwaddr addr, uint64_t val, unsigned size)
nvdimm_debug("Revision %#x Handler %#x Function %#x.\n", in->revision,
in->handle, in->function);
+ if (in->revision != 0x1 /* Currently we only support DSM Spec Rev1. */) {
+ nvdimm_debug("Revision %#x is not supported, expect %#x.\n",
+ in->revision, 0x1);
+ nvdimm_dsm_no_payload(1 /* Not Supported */, dsm_mem_addr);
+ goto exit;
+ }
+
/* Handle 0 is reserved for NVDIMM Root Device. */
if (!in->handle) {
nvdimm_dsm_root(in, dsm_mem_addr);
--
1.8.3.1
next prev parent reply other threads:[~2016-06-17 11:19 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-17 11:08 [Qemu-devel] [PATCH v5 00/13] NVDIMM: introduce nvdimm label support Xiao Guangrong
2016-06-17 11:08 ` [Qemu-devel] [PATCH v5 01/13] pc-dimm: introduce get_vmstate_memory_region callback Xiao Guangrong
2016-06-17 11:08 ` [Qemu-devel] [PATCH v5 02/13] nvdimm: support nvdimm label Xiao Guangrong
2016-06-17 11:08 ` [Qemu-devel] [PATCH v5 03/13] acpi: add aml_object_type Xiao Guangrong
2016-06-17 11:08 ` [Qemu-devel] [PATCH v5 04/13] acpi: add aml_call5 Xiao Guangrong
2016-06-17 11:08 ` [Qemu-devel] [PATCH v5 05/13] nvdimm acpi: set HDLE properly Xiao Guangrong
2016-06-17 11:08 ` [Qemu-devel] [PATCH v5 06/13] nvdimm acpi: save arg3 of _DSM method Xiao Guangrong
2016-06-17 11:08 ` [Qemu-devel] [PATCH v5 07/13] nvdimm acpi: check UUID Xiao Guangrong
2016-06-17 11:08 ` [Qemu-devel] [PATCH v5 08/13] nvdimm acpi: abstract the operations for root & nvdimm devices Xiao Guangrong
2016-06-17 11:08 ` Xiao Guangrong [this message]
2016-06-17 11:08 ` [Qemu-devel] [PATCH v5 10/13] nvdimm acpi: support Get Namespace Label Size function Xiao Guangrong
2016-06-17 11:08 ` [Qemu-devel] [PATCH v5 11/13] nvdimm acpi: support Get Namespace Label Data function Xiao Guangrong
2016-06-17 11:08 ` [Qemu-devel] [PATCH v5 12/13] nvdimm acpi: support Set " Xiao Guangrong
2016-06-17 11:08 ` [Qemu-devel] [PATCH v5 13/13] docs: add NVDIMM ACPI documentation Xiao Guangrong
2016-06-22 19:19 ` [Qemu-devel] [PATCH v5 00/13] NVDIMM: introduce nvdimm label support Stefan Hajnoczi
2016-06-22 22:10 ` Michael S. Tsirkin
2016-06-23 8:22 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1466161696-99298-10-git-send-email-guangrong.xiao@linux.intel.com \
--to=guangrong.xiao@linux.intel.com \
--cc=kvm@vger.kernel.org \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).