* [Qemu-devel] [PATCH] target-i386: TCG can support CPUID.07H:EBX.erms
@ 2016-06-17 15:47 Paolo Bonzini
2016-06-21 18:27 ` Eduardo Habkost
0 siblings, 1 reply; 2+ messages in thread
From: Paolo Bonzini @ 2016-06-17 15:47 UTC (permalink / raw)
To: qemu-devel; +Cc: ehabkost
ERMS just says "rep movsb" and "rep stosb" are fast. It does not
imply any new instruction, so we can support it easily.
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
target-i386/cpu.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/target-i386/cpu.c b/target-i386/cpu.c
index 3665fec..3871eb8 100644
--- a/target-i386/cpu.c
+++ b/target-i386/cpu.c
@@ -358,10 +358,11 @@ static const char *cpuid_6_feature_name[] = {
#define TCG_7_0_EBX_FEATURES (CPUID_7_0_EBX_SMEP | CPUID_7_0_EBX_SMAP | \
CPUID_7_0_EBX_BMI1 | CPUID_7_0_EBX_BMI2 | CPUID_7_0_EBX_ADX | \
CPUID_7_0_EBX_PCOMMIT | CPUID_7_0_EBX_CLFLUSHOPT | \
- CPUID_7_0_EBX_CLWB | CPUID_7_0_EBX_MPX | CPUID_7_0_EBX_FSGSBASE)
+ CPUID_7_0_EBX_CLWB | CPUID_7_0_EBX_MPX | CPUID_7_0_EBX_FSGSBASE | \
+ CPUID_7_0_EBX_ERMS)
/* missing:
CPUID_7_0_EBX_HLE, CPUID_7_0_EBX_AVX2,
- CPUID_7_0_EBX_ERMS, CPUID_7_0_EBX_INVPCID, CPUID_7_0_EBX_RTM,
+ CPUID_7_0_EBX_INVPCID, CPUID_7_0_EBX_RTM,
CPUID_7_0_EBX_RDSEED */
#define TCG_7_0_ECX_FEATURES (CPUID_7_0_ECX_PKU | CPUID_7_0_ECX_OSPKE)
#define TCG_APM_FEATURES 0
--
2.5.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Qemu-devel] [PATCH] target-i386: TCG can support CPUID.07H:EBX.erms
2016-06-17 15:47 [Qemu-devel] [PATCH] target-i386: TCG can support CPUID.07H:EBX.erms Paolo Bonzini
@ 2016-06-21 18:27 ` Eduardo Habkost
0 siblings, 0 replies; 2+ messages in thread
From: Eduardo Habkost @ 2016-06-21 18:27 UTC (permalink / raw)
To: Paolo Bonzini; +Cc: qemu-devel
On Fri, Jun 17, 2016 at 05:47:13PM +0200, Paolo Bonzini wrote:
> ERMS just says "rep movsb" and "rep stosb" are fast. It does not
> imply any new instruction, so we can support it easily.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Reviewed-by: Eduardo Habkost <ehabkost@redhat.com>
Applied to x86-next. Thanks.
> ---
> target-i386/cpu.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/target-i386/cpu.c b/target-i386/cpu.c
> index 3665fec..3871eb8 100644
> --- a/target-i386/cpu.c
> +++ b/target-i386/cpu.c
> @@ -358,10 +358,11 @@ static const char *cpuid_6_feature_name[] = {
> #define TCG_7_0_EBX_FEATURES (CPUID_7_0_EBX_SMEP | CPUID_7_0_EBX_SMAP | \
> CPUID_7_0_EBX_BMI1 | CPUID_7_0_EBX_BMI2 | CPUID_7_0_EBX_ADX | \
> CPUID_7_0_EBX_PCOMMIT | CPUID_7_0_EBX_CLFLUSHOPT | \
> - CPUID_7_0_EBX_CLWB | CPUID_7_0_EBX_MPX | CPUID_7_0_EBX_FSGSBASE)
> + CPUID_7_0_EBX_CLWB | CPUID_7_0_EBX_MPX | CPUID_7_0_EBX_FSGSBASE | \
> + CPUID_7_0_EBX_ERMS)
> /* missing:
> CPUID_7_0_EBX_HLE, CPUID_7_0_EBX_AVX2,
> - CPUID_7_0_EBX_ERMS, CPUID_7_0_EBX_INVPCID, CPUID_7_0_EBX_RTM,
> + CPUID_7_0_EBX_INVPCID, CPUID_7_0_EBX_RTM,
> CPUID_7_0_EBX_RDSEED */
> #define TCG_7_0_ECX_FEATURES (CPUID_7_0_ECX_PKU | CPUID_7_0_ECX_OSPKE)
> #define TCG_APM_FEATURES 0
> --
> 2.5.5
>
--
Eduardo
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-06-21 18:28 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-06-17 15:47 [Qemu-devel] [PATCH] target-i386: TCG can support CPUID.07H:EBX.erms Paolo Bonzini
2016-06-21 18:27 ` Eduardo Habkost
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).