From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:47548)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <benh@au1.ibm.com>) id 1bEPgk-00079j-6H
	for qemu-devel@nongnu.org; Sat, 18 Jun 2016 19:30:07 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <benh@au1.ibm.com>) id 1bEPgf-0005WZ-Vb
	for qemu-devel@nongnu.org; Sat, 18 Jun 2016 19:30:05 -0400
Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:52982)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <benh@au1.ibm.com>) id 1bEPgf-0005Vq-NJ
	for qemu-devel@nongnu.org; Sat, 18 Jun 2016 19:30:01 -0400
Received: from pps.filterd (m0098396.ppops.net [127.0.0.1])
	by mx0a-001b2d01.pphosted.com (8.16.0.11/8.16.0.11) with SMTP id
	u5INSmlK117283
	for <qemu-devel@nongnu.org>; Sat, 18 Jun 2016 19:29:58 -0400
Received: from e23smtp08.au.ibm.com (e23smtp08.au.ibm.com [202.81.31.141])
	by mx0a-001b2d01.pphosted.com with ESMTP id 23n0mcb3ne-1
	(version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT)
	for <qemu-devel@nongnu.org>; Sat, 18 Jun 2016 19:29:57 -0400
Received: from localhost
	by e23smtp08.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use
	Only! Violators will be prosecuted
	for <qemu-devel@nongnu.org> from <benh@au1.ibm.com>;
	Sun, 19 Jun 2016 09:29:55 +1000
From: Benjamin Herrenschmidt <benh@au1.ibm.com>
Reply-To: benh@au1.ibm.com
Date: Sun, 19 Jun 2016 09:29:50 +1000
In-Reply-To: <5763D3EF.6060305@kaod.org>
References: <1465795496-15071-1-git-send-email-clg@kaod.org>
Message-Id: <1466292590.24271.91.camel@au1.ibm.com>
Subject: Re: [Qemu-devel] [Qemu-ppc] [PATCH 01/10] ppc: Fix
 rfi/rfid/hrfi/... emulation
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?ISO-8859-1?Q?C=E9dric?= Le Goater <clg@kaod.org>, Thomas Huth <thuth@redhat.com>, David Gibson <david@gibson.dropbear.id.au>
Cc: qemu-ppc@nongnu.org, qemu-devel@nongnu.org

	
	<1465795496-15071-2-git-send-email-clg@kaod.org>
	
	
	<20160616010702.GI28087@voom.fritz.box>
	
	
	<20160617022731.GA19581@voom.fritz.box> <57639095.5010305@kaod.org>
	
	
	<576392B1.6030204@kaod.org> <5763A258.2010408@redhat.com>
	 <5763D3EF.6060305@kaod.org>
Organization: IBM Australia
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.20.3 (3.20.3-1.fc24) 
Mime-Version: 1.0
Content-Transfer-Encoding: 8bit

On Fri, 2016-06-17 at 12:41 +0200, Cédric Le Goater wrote:
> 
> This is too brutal :
> 
> +    /* This instruction doesn't exist anymore on 64-bit server
> +     * processors compliant with arch 2.x
> +     */
> +    if (ctx->insns_flags & PPC_SEGMENT_64B) {
> +        gen_inval_exception(ctx, POWERPC_EXCP_INVAL_INVAL);
> +        return;
> +    }
>         
> 
> There are a couple of instructions which have been deleted from 
> ISA 2.x. rfi is one of them. Could we use a insn_flag to filter
> them  ? 

Why is it too brutal ? We don't really support pre-arch 2.0 64-bit
processors do we ?

Cheers,
Ben.