From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47789) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bEzqA-000834-KM for qemu-devel@nongnu.org; Mon, 20 Jun 2016 10:06:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bEzq3-00077l-EW for qemu-devel@nongnu.org; Mon, 20 Jun 2016 10:06:13 -0400 Received: from mx1.redhat.com ([209.132.183.28]:48099) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bEzq3-00077Y-5r for qemu-devel@nongnu.org; Mon, 20 Jun 2016 10:06:07 -0400 From: Stefan Hajnoczi Date: Mon, 20 Jun 2016 15:05:25 +0100 Message-Id: <1466431531-17806-15-git-send-email-stefanha@redhat.com> In-Reply-To: <1466431531-17806-1-git-send-email-stefanha@redhat.com> References: <1466431531-17806-1-git-send-email-stefanha@redhat.com> Subject: [Qemu-devel] [PULL 14/20] blockjob: rename block_job_is_paused() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Peter Maydell , Stefan Hajnoczi The block_job_is_paused() function name is not great because callers only use it to determine whether pausing has been requested. Rename it to highlight those semantics and remove it from the public header file as there are no external callers. Signed-off-by: Stefan Hajnoczi Reviewed-by: Paolo Bonzini Reviewed-by: Fam Zheng Message-id: 1466096189-6477-3-git-send-email-stefanha@redhat.com --- blockjob.c | 6 +++--- include/block/blockjob.h | 9 --------- 2 files changed, 3 insertions(+), 12 deletions(-) diff --git a/blockjob.c b/blockjob.c index 5137dce..21cc3ee 100644 --- a/blockjob.c +++ b/blockjob.c @@ -252,7 +252,7 @@ void block_job_pause(BlockJob *job) job->pause_count++; } -bool block_job_is_paused(BlockJob *job) +static bool block_job_should_pause(BlockJob *job) { return job->pause_count > 0; } @@ -361,11 +361,11 @@ void block_job_sleep_ns(BlockJob *job, QEMUClockType type, int64_t ns) } job->busy = false; - if (!block_job_is_paused(job)) { + if (!block_job_should_pause(job)) { co_aio_sleep_ns(blk_get_aio_context(job->blk), type, ns); } /* The job can be paused while sleeping, so check this again */ - if (block_job_is_paused(job)) { + if (block_job_should_pause(job)) { qemu_coroutine_yield(); } job->busy = true; diff --git a/include/block/blockjob.h b/include/block/blockjob.h index 00ac418..8fcecf9 100644 --- a/include/block/blockjob.h +++ b/include/block/blockjob.h @@ -348,15 +348,6 @@ void block_job_event_completed(BlockJob *job, const char *msg); void block_job_event_ready(BlockJob *job); /** - * block_job_is_paused: - * @job: The job being queried. - * - * Returns whether the job is currently paused, or will pause - * as soon as it reaches a sleeping point. - */ -bool block_job_is_paused(BlockJob *job); - -/** * block_job_cancel_sync: * @job: The job to be canceled. * -- 2.5.5