From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56122) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bF0MK-00023o-2g for qemu-devel@nongnu.org; Mon, 20 Jun 2016 10:39:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bF0MH-000503-AT for qemu-devel@nongnu.org; Mon, 20 Jun 2016 10:39:26 -0400 Received: from mail-wm0-x243.google.com ([2a00:1450:400c:c09::243]:34975) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bF0MH-0004zr-3n for qemu-devel@nongnu.org; Mon, 20 Jun 2016 10:39:25 -0400 Received: by mail-wm0-x243.google.com with SMTP id a66so9520133wme.2 for ; Mon, 20 Jun 2016 07:39:25 -0700 (PDT) Sender: Paolo Bonzini From: Paolo Bonzini Date: Mon, 20 Jun 2016 16:39:17 +0200 Message-Id: <1466433559-30930-2-git-send-email-pbonzini@redhat.com> In-Reply-To: <1466433559-30930-1-git-send-email-pbonzini@redhat.com> References: <1466433559-30930-1-git-send-email-pbonzini@redhat.com> Subject: [Qemu-devel] [PATCH 1/3] ich9: call ich9_lpc_update_pic for disabled pirqs List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: real@ispras.ru An asserted pirq can be disabled and the corresponding GSIs should then go down to 0. However, because of the conditional in ich9_lpc_update_by_pirq, the legacy 8259 pin could remain stuck to 1. Signed-off-by: Paolo Bonzini --- hw/isa/lpc_ich9.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/hw/isa/lpc_ich9.c b/hw/isa/lpc_ich9.c index 213741b..b116e1b 100644 --- a/hw/isa/lpc_ich9.c +++ b/hw/isa/lpc_ich9.c @@ -234,9 +234,6 @@ static void ich9_lpc_update_by_pirq(ICH9LPCState *lpc, int pirq) ich9_lpc_pic_irq(lpc, pirq, &pic_irq, &pic_dis); assert(pic_irq < ICH9_LPC_PIC_NUM_PINS); - if (pic_dis) { - return; - } ich9_lpc_update_pic(lpc, pic_irq); } -- 2.5.5