From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35639) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bF0gi-0001Gd-8h for qemu-devel@nongnu.org; Mon, 20 Jun 2016 11:00:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bF0gf-00022Y-HY for qemu-devel@nongnu.org; Mon, 20 Jun 2016 11:00:31 -0400 Received: from mx1.redhat.com ([209.132.183.28]:37168) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bF0gf-00022C-AE for qemu-devel@nongnu.org; Mon, 20 Jun 2016 11:00:29 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 6ABBCC0740E5 for ; Mon, 20 Jun 2016 15:00:28 +0000 (UTC) Received: from blackfin.pond.sub.org (ovpn-116-49.ams2.redhat.com [10.36.116.49]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u5KF0QjC022770 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO) for ; Mon, 20 Jun 2016 11:00:28 -0400 From: Markus Armbruster Date: Mon, 20 Jun 2016 17:00:21 +0200 Message-Id: <1466434823-22789-6-git-send-email-armbru@redhat.com> In-Reply-To: <1466434823-22789-1-git-send-email-armbru@redhat.com> References: <1466434823-22789-1-git-send-email-armbru@redhat.com> Subject: [Qemu-devel] [PULL 5/7] log: Plug memory leak on multiple -dfilter List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org -dfilter overwrites any previous filter. The overwritten filter is leaked. Leaks since the beginning (commit 3514552, v2.6.0). Free it properly. Signed-off-by: Markus Armbruster Message-Id: <1466011636-6112-2-git-send-email-armbru@redhat.com> Reviewed-by: Eric Blake --- util/log.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/util/log.c b/util/log.c index 5ad72c1..6f45e0a 100644 --- a/util/log.c +++ b/util/log.c @@ -145,9 +145,16 @@ bool qemu_log_in_addr_range(uint64_t addr) void qemu_set_dfilter_ranges(const char *filter_spec) { gchar **ranges = g_strsplit(filter_spec, ",", 0); + + if (debug_regions) { + g_array_unref(debug_regions); + debug_regions = NULL; + } + if (ranges) { gchar **next = ranges; gchar *r = *next++; + debug_regions = g_array_sized_new(FALSE, FALSE, sizeof(Range), g_strv_length(ranges)); while (r) { -- 2.5.5