From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34831) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bF252-0005uC-Md for qemu-devel@nongnu.org; Mon, 20 Jun 2016 12:29:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bF24v-00052q-E0 for qemu-devel@nongnu.org; Mon, 20 Jun 2016 12:29:43 -0400 Received: from mx1.redhat.com ([209.132.183.28]:46270) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bF24v-00052b-8j for qemu-devel@nongnu.org; Mon, 20 Jun 2016 12:29:37 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id E0EB12CAF07 for ; Mon, 20 Jun 2016 16:29:36 +0000 (UTC) From: Markus Armbruster Date: Mon, 20 Jun 2016 18:29:33 +0200 Message-Id: <1466440173-21990-5-git-send-email-armbru@redhat.com> In-Reply-To: <1466440173-21990-1-git-send-email-armbru@redhat.com> References: <1466440173-21990-1-git-send-email-armbru@redhat.com> Subject: [Qemu-devel] [PATCH v2 4/4] log: Permit -dfilter 0..0xffffffffffffffff List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: eblake@redhat.com, mst@redhat.com, pbonzini@redhat.com Works fine since the previous commit fixed the underlying range data type. Of course it filters out nothing, but so does 0..1,2..0xffffffffffffffff, and we don't bother rejecting that either. Signed-off-by: Markus Armbruster --- tests/test-logging.c | 5 +++-- util/log.c | 2 +- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/tests/test-logging.c b/tests/test-logging.c index b6fa94e..cdf13c6 100644 --- a/tests/test-logging.c +++ b/tests/test-logging.c @@ -73,8 +73,9 @@ static void test_parse_range(void) g_assert_false(qemu_log_in_addr_range(UINT64_MAX - 1)); qemu_set_dfilter_ranges("0..0xffffffffffffffff", &err); - error_free_or_abort(&err); - + g_assert(qemu_log_in_addr_range(0)); + g_assert(qemu_log_in_addr_range(UINT64_MAX)); + qemu_set_dfilter_ranges("2..1", &err); error_free_or_abort(&err); diff --git a/util/log.c b/util/log.c index 4da635c..b6c75b1 100644 --- a/util/log.c +++ b/util/log.c @@ -204,7 +204,7 @@ void qemu_set_dfilter_ranges(const char *filter_spec, Error **errp) default: g_assert_not_reached(); } - if (lob > upb || (lob == 0 && upb == UINT64_MAX)) { + if (lob > upb) { error_setg(errp, "Invalid range"); goto out; } -- 2.5.5