qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Hajnoczi <stefanha@redhat.com>
To: qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>,
	Roman Pen <roman.penyaev@profitbricks.com>,
	Fam Zheng <famz@redhat.com>,
	Christian Borntraeger <borntraeger@de.ibm.com>,
	Paolo Bonzini <pbonzini@redhat.com>,
	Ming Lei <ming.lei@canonical.com>,
	Stefan Hajnoczi <stefanha@redhat.com>
Subject: [Qemu-devel] [PATCH v4 5/7] virtio-blk: live migrate s->rq with multiqueue
Date: Tue, 21 Jun 2016 13:13:14 +0100	[thread overview]
Message-ID: <1466511196-12612-6-git-send-email-stefanha@redhat.com> (raw)
In-Reply-To: <1466511196-12612-1-git-send-email-stefanha@redhat.com>

Add a field for the virtqueue index when migrating the s->rq request
list.  The new field is only needed when num_queues > 1.  Existing QEMUs
are unaffected by this change and therefore virtio-blk migration stays
compatible.

Suggested-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
---
 hw/block/virtio-blk.c | 20 +++++++++++++++++++-
 1 file changed, 19 insertions(+), 1 deletion(-)

diff --git a/hw/block/virtio-blk.c b/hw/block/virtio-blk.c
index 222611c..2ea8766 100644
--- a/hw/block/virtio-blk.c
+++ b/hw/block/virtio-blk.c
@@ -813,6 +813,11 @@ static void virtio_blk_save_device(VirtIODevice *vdev, QEMUFile *f)
 
     while (req) {
         qemu_put_sbyte(f, 1);
+
+        if (s->conf.num_queues > 1) {
+            qemu_put_be32(f, virtio_get_queue_index(req->vq));
+        }
+
         qemu_put_virtqueue_element(f, &req->elem);
         req = req->next;
     }
@@ -836,9 +841,22 @@ static int virtio_blk_load_device(VirtIODevice *vdev, QEMUFile *f,
     VirtIOBlock *s = VIRTIO_BLK(vdev);
 
     while (qemu_get_sbyte(f)) {
+        unsigned nvqs = s->conf.num_queues;
+        unsigned vq_idx = 0;
         VirtIOBlockReq *req;
+
+        if (nvqs > 1) {
+            vq_idx = qemu_get_be32(f);
+
+            if (vq_idx >= nvqs) {
+                error_report("Invalid virtqueue index in request list: %#x",
+                             vq_idx);
+                return -EINVAL;
+            }
+        }
+
         req = qemu_get_virtqueue_element(f, sizeof(VirtIOBlockReq));
-        virtio_blk_init_request(s, s->vq, req);
+        virtio_blk_init_request(s, virtio_get_queue(vdev, vq_idx), req);
         req->next = s->rq;
         s->rq = req;
     }
-- 
2.5.5

  parent reply	other threads:[~2016-06-21 12:13 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-21 12:13 [Qemu-devel] [PATCH v4 0/7] virtio-blk: multiqueue support Stefan Hajnoczi
2016-06-21 12:13 ` [Qemu-devel] [PATCH v4 1/7] virtio-blk: add VirtIOBlockConf->num_queues Stefan Hajnoczi
2016-06-21 12:13 ` [Qemu-devel] [PATCH v4 2/7] virtio-blk: multiqueue batch notify Stefan Hajnoczi
2016-06-21 12:13 ` [Qemu-devel] [PATCH v4 3/7] virtio-blk: tell dataplane which vq to notify Stefan Hajnoczi
2016-06-21 12:13 ` [Qemu-devel] [PATCH v4 4/7] virtio-blk: associate request with a virtqueue Stefan Hajnoczi
2016-06-21 12:13 ` Stefan Hajnoczi [this message]
2016-06-21 12:13 ` [Qemu-devel] [PATCH v4 6/7] virtio-blk: dataplane multiqueue support Stefan Hajnoczi
2016-06-21 12:13 ` [Qemu-devel] [PATCH v4 7/7] virtio-blk: add num-queues device property Stefan Hajnoczi
2016-06-21 12:25 ` [Qemu-devel] [PATCH v4 0/7] virtio-blk: multiqueue support Christian Borntraeger
2016-06-21 13:28   ` Stefan Hajnoczi
2016-06-21 13:30     ` Stefan Hajnoczi
2016-06-22  6:16 ` Fam Zheng
2016-06-24  9:39 ` Stefan Hajnoczi
2016-06-24 15:32 ` [Qemu-devel] [RFC v2] virtio-blk: simple multithreaded MQ implementation for bdrv_raw Roman Pen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1466511196-12612-6-git-send-email-stefanha@redhat.com \
    --to=stefanha@redhat.com \
    --cc=borntraeger@de.ibm.com \
    --cc=famz@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=ming.lei@canonical.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=roman.penyaev@profitbricks.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).