qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Dr. David Alan Gilbert (git)" <dgilbert@redhat.com>
To: qemu-devel@nongnu.org, mst@redhat.com, amit.shah@redhat.com,
	quintela@redhat.com, kraxel@redhat.com
Subject: [Qemu-devel] [PATCH 07/13] virtio-balloon: Wrap in vmstate
Date: Tue, 21 Jun 2016 20:14:01 +0100	[thread overview]
Message-ID: <1466536447-30146-8-git-send-email-dgilbert@redhat.com> (raw)
In-Reply-To: <1466536447-30146-1-git-send-email-dgilbert@redhat.com>

From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>

Forcibly convert it to a vmstate wrapper;  proper conversion
comes later.

Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
---
 hw/virtio/virtio-balloon.c | 19 +++++--------------
 1 file changed, 5 insertions(+), 14 deletions(-)

diff --git a/hw/virtio/virtio-balloon.c b/hw/virtio/virtio-balloon.c
index 557d3f9..22894f3 100644
--- a/hw/virtio/virtio-balloon.c
+++ b/hw/virtio/virtio-balloon.c
@@ -396,11 +396,6 @@ static void virtio_balloon_to_target(void *opaque, ram_addr_t target)
     trace_virtio_balloon_to_target(target, dev->num_pages);
 }
 
-static void virtio_balloon_save(QEMUFile *f, void *opaque)
-{
-    virtio_save(VIRTIO_DEVICE(opaque), f);
-}
-
 static void virtio_balloon_save_device(VirtIODevice *vdev, QEMUFile *f)
 {
     VirtIOBalloon *s = VIRTIO_BALLOON(vdev);
@@ -409,12 +404,9 @@ static void virtio_balloon_save_device(VirtIODevice *vdev, QEMUFile *f)
     qemu_put_be32(f, s->actual);
 }
 
-static int virtio_balloon_load(QEMUFile *f, void *opaque, int version_id)
+static int virtio_balloon_load(QEMUFile *f, void *opaque, size_t size)
 {
-    if (version_id != 1)
-        return -EINVAL;
-
-    return virtio_load(VIRTIO_DEVICE(opaque), f, version_id);
+    return virtio_load(VIRTIO_DEVICE(opaque), f, 1);
 }
 
 static int virtio_balloon_load_device(VirtIODevice *vdev, QEMUFile *f,
@@ -454,9 +446,6 @@ static void virtio_balloon_device_realize(DeviceState *dev, Error **errp)
     s->svq = virtio_add_queue(vdev, 128, virtio_balloon_receive_stats);
 
     reset_stats(s);
-
-    register_savevm(dev, "virtio-balloon", -1, 1,
-                    virtio_balloon_save, virtio_balloon_load, s);
 }
 
 static void virtio_balloon_device_unrealize(DeviceState *dev, Error **errp)
@@ -466,7 +455,6 @@ static void virtio_balloon_device_unrealize(DeviceState *dev, Error **errp)
 
     balloon_stats_destroy_timer(s);
     qemu_remove_balloon_handler(s);
-    unregister_savevm(dev, "virtio-balloon", s);
     virtio_cleanup(vdev);
 }
 
@@ -493,6 +481,8 @@ static void virtio_balloon_instance_init(Object *obj)
                         NULL, s, NULL);
 }
 
+VMSTATE_VIRTIO_DEVICE(balloon, 1, virtio_balloon_load, virtio_vmstate_save);
+
 static Property virtio_balloon_properties[] = {
     DEFINE_PROP_BIT("deflate-on-oom", VirtIOBalloon, host_features,
                     VIRTIO_BALLOON_F_DEFLATE_ON_OOM, false),
@@ -505,6 +495,7 @@ static void virtio_balloon_class_init(ObjectClass *klass, void *data)
     VirtioDeviceClass *vdc = VIRTIO_DEVICE_CLASS(klass);
 
     dc->props = virtio_balloon_properties;
+    dc->vmsd = &vmstate_virtio_balloon;
     set_bit(DEVICE_CATEGORY_MISC, dc->categories);
     vdc->realize = virtio_balloon_device_realize;
     vdc->unrealize = virtio_balloon_device_unrealize;
-- 
2.7.4

  parent reply	other threads:[~2016-06-21 19:14 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-21 19:13 [Qemu-devel] [PATCH 00/13] virtio migration: Flip outer layer to vmstate Dr. David Alan Gilbert (git)
2016-06-21 19:13 ` [Qemu-devel] [PATCH 01/13] virtio-net: Remove old migration version support Dr. David Alan Gilbert (git)
2016-06-27  6:46   ` Amit Shah
2016-06-21 19:13 ` [Qemu-devel] [PATCH 02/13] virtio-serial: " Dr. David Alan Gilbert (git)
2016-06-27  6:45   ` Amit Shah
2016-06-21 19:13 ` [Qemu-devel] [PATCH 03/13] virtio: Migration helper function and macro Dr. David Alan Gilbert (git)
2016-06-22 17:39   ` Cornelia Huck
2016-06-21 19:13 ` [Qemu-devel] [PATCH 04/13] virtio-scsi: Wrap in vmstate Dr. David Alan Gilbert (git)
2016-06-22 17:40   ` Cornelia Huck
2016-06-21 19:13 ` [Qemu-devel] [PATCH 05/13] virtio-blk: " Dr. David Alan Gilbert (git)
2016-06-22 17:42   ` Cornelia Huck
2016-06-21 19:14 ` [Qemu-devel] [PATCH 06/13] virtio-rng: " Dr. David Alan Gilbert (git)
2016-06-22 17:44   ` Cornelia Huck
2016-06-21 19:14 ` Dr. David Alan Gilbert (git) [this message]
2016-06-22 17:46   ` [Qemu-devel] [PATCH 07/13] virtio-balloon: " Cornelia Huck
2016-06-21 19:14 ` [Qemu-devel] [PATCH 08/13] virtio-net: " Dr. David Alan Gilbert (git)
2016-06-23  7:39   ` Cornelia Huck
2016-06-21 19:14 ` [Qemu-devel] [PATCH 09/13] virtio-serial: " Dr. David Alan Gilbert (git)
2016-06-23  7:55   ` Cornelia Huck
2016-06-21 19:14 ` [Qemu-devel] [PATCH 10/13] 9pfs: " Dr. David Alan Gilbert (git)
2016-06-23  8:01   ` Cornelia Huck
2016-06-30  7:02   ` Greg Kurz
2016-06-21 19:14 ` [Qemu-devel] [PATCH 11/13] virtio-input: " Dr. David Alan Gilbert (git)
2016-06-22  6:48   ` Gerd Hoffmann
2016-06-22  9:54     ` Dr. David Alan Gilbert
2016-06-22 10:29       ` Gerd Hoffmann
2016-06-23  8:07   ` Cornelia Huck
2016-06-21 19:14 ` [Qemu-devel] [PATCH 12/13] virtio-gpu: " Dr. David Alan Gilbert (git)
2016-06-23  8:19   ` Cornelia Huck
2016-06-21 19:14 ` [Qemu-devel] [PATCH 13/13] virtio: Update migration docs Dr. David Alan Gilbert (git)
2016-06-23  8:23   ` Cornelia Huck
2016-06-22  6:53 ` [Qemu-devel] [PATCH 00/13] virtio migration: Flip outer layer to vmstate Gerd Hoffmann
2016-06-22  9:50   ` Dr. David Alan Gilbert
2016-06-22  8:39 ` Cornelia Huck
2016-06-22 10:54   ` Dr. David Alan Gilbert
2016-06-22 17:36     ` Cornelia Huck
2016-06-24  5:49 ` Michael S. Tsirkin
2016-06-24  8:02   ` Dr. David Alan Gilbert
2016-06-27  6:50 ` Amit Shah
2016-06-27  7:53   ` Dr. David Alan Gilbert
2016-06-28  9:04     ` Amit Shah

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1466536447-30146-8-git-send-email-dgilbert@redhat.com \
    --to=dgilbert@redhat.com \
    --cc=amit.shah@redhat.com \
    --cc=kraxel@redhat.com \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).