From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59564) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bFTZF-0002V6-Us for qemu-devel@nongnu.org; Tue, 21 Jun 2016 17:50:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bFTZA-0001Eq-Pa for qemu-devel@nongnu.org; Tue, 21 Jun 2016 17:50:46 -0400 Received: from 14.mo1.mail-out.ovh.net ([178.32.97.215]:36702) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bFTZA-0001Ee-Id for qemu-devel@nongnu.org; Tue, 21 Jun 2016 17:50:40 -0400 Received: from player770.ha.ovh.net (b7.ovh.net [213.186.33.57]) by mo1.mail-out.ovh.net (Postfix) with ESMTP id 9A1B4FF9C07 for ; Tue, 21 Jun 2016 23:50:39 +0200 (CEST) From: =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= Date: Tue, 21 Jun 2016 23:48:54 +0200 Message-Id: <1466545735-2555-10-git-send-email-clg@kaod.org> In-Reply-To: <1466545735-2555-1-git-send-email-clg@kaod.org> References: <1466545735-2555-1-git-send-email-clg@kaod.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: [Qemu-devel] [PATCH v2 09/10] ppc: Move exception generation code out of line List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-ppc@nongnu.org Cc: David Gibson , Alexander Graf , qemu-devel@nongnu.org, Benjamin Herrenschmidt , Cedric Le Goater From: Benjamin Herrenschmidt There's no point inlining this, if you hit the exception case you exit anyway, and not inlining saves about 100K of code size (and cache footprint). Signed-off-by: Benjamin Herrenschmidt [clg: removed '__attribute__((noinline))' from original patch ] Signed-off-by: C=C3=A9dric Le Goater --- target-ppc/translate.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/target-ppc/translate.c b/target-ppc/translate.c index 83ec2dd7707b..365fe3d34461 100644 --- a/target-ppc/translate.c +++ b/target-ppc/translate.c @@ -283,7 +283,7 @@ void gen_update_current_nip(void *opaque) tcg_gen_movi_tl(cpu_nip, ctx->nip); } =20 -static inline void gen_exception_err(DisasContext *ctx, uint32_t excp, u= int32_t error) +static void gen_exception_err(DisasContext *ctx, uint32_t excp, uint32_t= error) { TCGv_i32 t0, t1; if (ctx->exception =3D=3D POWERPC_EXCP_NONE) { @@ -297,7 +297,7 @@ static inline void gen_exception_err(DisasContext *ct= x, uint32_t excp, uint32_t ctx->exception =3D (excp); } =20 -static inline void gen_exception(DisasContext *ctx, uint32_t excp) +static void gen_exception(DisasContext *ctx, uint32_t excp) { TCGv_i32 t0; if (ctx->exception =3D=3D POWERPC_EXCP_NONE) { @@ -309,7 +309,7 @@ static inline void gen_exception(DisasContext *ctx, u= int32_t excp) ctx->exception =3D (excp); } =20 -static inline void gen_debug_exception(DisasContext *ctx) +static void gen_debug_exception(DisasContext *ctx) { TCGv_i32 t0; =20 --=20 2.1.4