From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:50674)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1bFfPu-0006e6-RN
	for qemu-devel@nongnu.org; Wed, 22 Jun 2016 06:29:55 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1bFfPr-0000h1-Go
	for qemu-devel@nongnu.org; Wed, 22 Jun 2016 06:29:54 -0400
Received: from mx1.redhat.com ([209.132.183.28]:56097)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1bFfPr-0000gJ-BA
	for qemu-devel@nongnu.org; Wed, 22 Jun 2016 06:29:51 -0400
Received: from int-mx13.intmail.prod.int.phx2.redhat.com
	(int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by mx1.redhat.com (Postfix) with ESMTPS id 2F6BD3F725
	for <qemu-devel@nongnu.org>; Wed, 22 Jun 2016 10:29:50 +0000 (UTC)
Message-ID: <1466591388.16954.50.camel@redhat.com>
From: Gerd Hoffmann <kraxel@redhat.com>
Date: Wed, 22 Jun 2016 12:29:48 +0200
In-Reply-To: <20160622095452.GB2274@work-vm>
References: <1466536447-30146-1-git-send-email-dgilbert@redhat.com>
	<1466536447-30146-12-git-send-email-dgilbert@redhat.com>
	<1466578084.16954.17.camel@redhat.com> <20160622095452.GB2274@work-vm>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Mime-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 11/13] virtio-input: Wrap in vmstate
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
Cc: qemu-devel@nongnu.org, mst@redhat.com, amit.shah@redhat.com, quintela@redhat.com

On Mi, 2016-06-22 at 10:54 +0100, Dr. David Alan Gilbert wrote:
> * Gerd Hoffmann (kraxel@redhat.com) wrote:
> > On Di, 2016-06-21 at 20:14 +0100, Dr. David Alan Gilbert (git) wrote:
> > > From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
> > >=20
> > > Forcibly convert it to a vmstate wrapper;  proper conversion
> > > comes later.
> >=20
> > FYI: Should be an easy target for proper conversion as virtio-input
> > doesn't need to save any device-specific state beside the usual virtio
> > and pci bits.
>=20
> Thanks; what would a good test for virtio-input to be to make sure
> migration works; got a recommended command line?

Drop "-device usb-tablet", add "-device virtio-tablet-pci" instead,
mouse input should continue to work just fine (assuming your guest
kernel is new enough).

cheers,
  Gerd