qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Efimov Vasily <real@ispras.ru>
To: qemu-devel@nongnu.org
Cc: "Efimov Vasily" <real@ispras.ru>, "John Snow" <jsnow@redhat.com>,
	qemu-block@nongnu.org, "Gerd Hoffmann" <kraxel@redhat.com>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	"Kevin Wolf" <kwolf@redhat.com>, "Max Reitz" <mreitz@redhat.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Richard Henderson" <rth@twiddle.net>,
	"Eduardo Habkost" <ehabkost@redhat.com>,
	"Hervé Poussineau" <hpoussin@reactos.org>,
	"Markus Armbruster" <armbru@redhat.com>,
	"Marcel Apfelbaum" <marcel@redhat.com>,
	"Peter Maydell" <peter.maydell@linaro.org>,
	"Kirill Batuzov" <batuzovk@ispras.ru>
Subject: [Qemu-devel] [PATCH v2 03/14] vmport: identify vmport type by macro TYPE_VMPORT
Date: Wed, 22 Jun 2016 15:24:47 +0300	[thread overview]
Message-ID: <1466598298-21214-4-git-send-email-real@ispras.ru> (raw)
In-Reply-To: <1466598298-21214-1-git-send-email-real@ispras.ru>

Currently vmport device is identified by the string literal. Using a
preprocessor alias instead is preferable.

Signed-off-by: Efimov Vasily <real@ispras.ru>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
---
 hw/misc/vmport.c     | 1 -
 include/hw/i386/pc.h | 3 ++-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/hw/misc/vmport.c b/hw/misc/vmport.c
index 6896789..c763811 100644
--- a/hw/misc/vmport.c
+++ b/hw/misc/vmport.c
@@ -36,7 +36,6 @@
 #define VMPORT_ENTRIES 0x2c
 #define VMPORT_MAGIC   0x564D5868
 
-#define TYPE_VMPORT "vmport"
 #define VMPORT(obj) OBJECT_CHECK(VMPortState, (obj), TYPE_VMPORT)
 
 typedef struct VMPortState
diff --git a/include/hw/i386/pc.h b/include/hw/i386/pc.h
index 49566c8..dc7503d 100644
--- a/include/hw/i386/pc.h
+++ b/include/hw/i386/pc.h
@@ -199,11 +199,12 @@ typedef struct GSIState {
 void gsi_handler(void *opaque, int n, int level);
 
 /* vmport.c */
+#define TYPE_VMPORT "vmport"
 typedef uint32_t (VMPortReadFunc)(void *opaque, uint32_t address);
 
 static inline void vmport_init(ISABus *bus)
 {
-    isa_create_simple(bus, "vmport");
+    isa_create_simple(bus, TYPE_VMPORT);
 }
 
 void vmport_register(unsigned char command, VMPortReadFunc *func, void *opaque);
-- 
2.7.4

  parent reply	other threads:[~2016-06-22 12:25 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-22 12:24 [Qemu-devel] [PATCH v2 00/14] Make Q35 devices closer to Qemu object model Efimov Vasily
2016-06-22 12:24 ` [Qemu-devel] [PATCH v2 01/14] ide: move headers to include folder Efimov Vasily
2016-06-22 12:24 ` [Qemu-devel] [PATCH v2 02/14] pcspk: convert "pit" property type from ptr to link Efimov Vasily
2016-06-22 12:24 ` Efimov Vasily [this message]
2016-06-22 12:24 ` [Qemu-devel] [PATCH v2 04/14] pflash: make TYPE_CFI_PFLASH0{1, 2} macros public Efimov Vasily
2016-06-22 12:24 ` [Qemu-devel] [PATCH v2 05/14] Q35: implement property interfece to several parameters Efimov Vasily
2016-06-22 12:24 ` [Qemu-devel] [PATCH v2 06/14] pc_q35: configure Q35 instance using properties Efimov Vasily
2016-06-22 12:24 ` [Qemu-devel] [PATCH v2 07/14] pckbd: handle A20 IRQ as GPIO Efimov Vasily
2016-06-22 12:24 ` [Qemu-devel] [PATCH v2 08/14] port92: " Efimov Vasily
2016-06-22 12:24 ` [Qemu-devel] [PATCH v2 09/14] ICH9 SMB: make TYPE_ICH9_SMB_DEVICE macro public Efimov Vasily
2016-06-22 12:24 ` [Qemu-devel] [PATCH v2 10/14] ICH9 LPC: handle GSI as qdev GPIO Efimov Vasily
2016-06-22 12:24 ` [Qemu-devel] [PATCH v2 11/14] ICH9 LPC: move call of isa_bus_irqs to 'realize' method Efimov Vasily
2016-06-22 12:24 ` [Qemu-devel] [PATCH v2 12/14] isa: introduce wrapper isa_connect_gpio_out Efimov Vasily
2016-06-22 12:24 ` [Qemu-devel] [PATCH v2 13/14] MC146818 RTC: add GPIO access to output IRQ Efimov Vasily
2016-06-22 12:24 ` [Qemu-devel] [PATCH v2 14/14] ICH9 LPC: configure PCI IRQs routing internally Efimov Vasily
2016-06-22 13:24 ` [Qemu-devel] [PATCH v2 00/14] Make Q35 devices closer to Qemu object model Paolo Bonzini
2016-06-22 18:27   ` Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1466598298-21214-4-git-send-email-real@ispras.ru \
    --to=real@ispras.ru \
    --cc=armbru@redhat.com \
    --cc=batuzovk@ispras.ru \
    --cc=ehabkost@redhat.com \
    --cc=hpoussin@reactos.org \
    --cc=jsnow@redhat.com \
    --cc=kraxel@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=marcel@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=rth@twiddle.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).