qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: John Snow <jsnow@redhat.com>
To: qemu-block@nongnu.org
Cc: kwolf@redhat.com, jcody@redhat.com, famz@redhat.com,
	qemu-devel@nongnu.org, mreitz@redhat.com,
	John Snow <jsnow@redhat.com>
Subject: [Qemu-devel] [PATCH 0/3] drive-mirror: limit niov to MAX_IOV
Date: Wed, 22 Jun 2016 15:51:01 -0400	[thread overview]
Message-ID: <1466625064-11280-1-git-send-email-jsnow@redhat.com> (raw)

e5b43573 caused a regression in the preparation of our IO vectors, such
that if a small granularity but a large buffer size is chosen, we may
accidentally exceed MAX_IOV and the request will fail.

This has been fixed before in cae98cb8, and now we'll fix it again.
To keep it fixed, we'll add an iotest this time.

[Thanks to Max for finding the root cause.]

John Snow (3):
  mirror: clarify mirror_do_read return code
  mirror: limit niov to IOV_MAX elements, again
  iotests: add small-granularity mirror test

 block/mirror.c             | 10 ++++++++--
 tests/qemu-iotests/041     | 30 ++++++++++++++++++++++++++++++
 tests/qemu-iotests/041.out |  4 ++--
 3 files changed, 40 insertions(+), 4 deletions(-)

-- 
2.4.11

             reply	other threads:[~2016-06-22 19:51 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-22 19:51 John Snow [this message]
2016-06-22 19:51 ` [Qemu-devel] [PATCH 1/3] mirror: clarify mirror_do_read return code John Snow
2016-06-22 20:03   ` Eric Blake
2016-06-23  0:36   ` Fam Zheng
2016-06-22 19:51 ` [Qemu-devel] [PATCH 2/3] mirror: limit niov to IOV_MAX elements, again John Snow
2016-06-22 20:29   ` Eric Blake
2016-06-23  0:39   ` Fam Zheng
2016-06-22 19:51 ` [Qemu-devel] [PATCH 3/3] iotests: add small-granularity mirror test John Snow
2016-06-22 20:36   ` Eric Blake
2016-06-23  0:47   ` Fam Zheng
2016-06-28 17:05 ` [Qemu-devel] [PATCH 0/3] drive-mirror: limit niov to MAX_IOV John Snow
2016-06-29  2:53 ` Jeff Cody

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1466625064-11280-1-git-send-email-jsnow@redhat.com \
    --to=jsnow@redhat.com \
    --cc=famz@redhat.com \
    --cc=jcody@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).