From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35990) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bFxTw-00079R-2x for qemu-devel@nongnu.org; Thu, 23 Jun 2016 01:47:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bFxTq-0002av-VV for qemu-devel@nongnu.org; Thu, 23 Jun 2016 01:47:15 -0400 From: David Gibson Date: Thu, 23 Jun 2016 15:48:44 +1000 Message-Id: <1466660926-1544-16-git-send-email-david@gibson.dropbear.id.au> In-Reply-To: <1466660926-1544-1-git-send-email-david@gibson.dropbear.id.au> References: <1466660926-1544-1-git-send-email-david@gibson.dropbear.id.au> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: [Qemu-devel] [PULL 15/17] ppc: Move exception generation code out of line List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: peter.maydell@linaro.org Cc: agraf@suse.de, qemu-ppc@nongnu.org, pbonzini@redhat.com, qemu-devel@nongnu.org, Benjamin Herrenschmidt , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , David Gibson From: Benjamin Herrenschmidt There's no point inlining this, if you hit the exception case you exit anyway, and not inlining saves about 100K of code size (and cache footprint). Signed-off-by: Benjamin Herrenschmidt [clg: removed '__attribute__((noinline))' from original patch ] Signed-off-by: C=C3=A9dric Le Goater Signed-off-by: David Gibson --- target-ppc/translate.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/target-ppc/translate.c b/target-ppc/translate.c index 55102bf..fcead98 100644 --- a/target-ppc/translate.c +++ b/target-ppc/translate.c @@ -284,7 +284,7 @@ void gen_update_current_nip(void *opaque) tcg_gen_movi_tl(cpu_nip, ctx->nip); } =20 -static inline void gen_exception_err(DisasContext *ctx, uint32_t excp, u= int32_t error) +static void gen_exception_err(DisasContext *ctx, uint32_t excp, uint32_t= error) { TCGv_i32 t0, t1; if (ctx->exception =3D=3D POWERPC_EXCP_NONE) { @@ -298,7 +298,7 @@ static inline void gen_exception_err(DisasContext *ct= x, uint32_t excp, uint32_t ctx->exception =3D (excp); } =20 -static inline void gen_exception(DisasContext *ctx, uint32_t excp) +static void gen_exception(DisasContext *ctx, uint32_t excp) { TCGv_i32 t0; if (ctx->exception =3D=3D POWERPC_EXCP_NONE) { @@ -310,7 +310,7 @@ static inline void gen_exception(DisasContext *ctx, u= int32_t excp) ctx->exception =3D (excp); } =20 -static inline void gen_debug_exception(DisasContext *ctx) +static void gen_debug_exception(DisasContext *ctx) { TCGv_i32 t0; =20 --=20 2.5.5