From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:59689)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1bFz4v-0007t1-9F
	for qemu-devel@nongnu.org; Thu, 23 Jun 2016 03:29:34 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1bFz4p-0001fo-9c
	for qemu-devel@nongnu.org; Thu, 23 Jun 2016 03:29:32 -0400
Received: from mx1.redhat.com ([209.132.183.28]:37612)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1bFz4p-0001fj-4p
	for qemu-devel@nongnu.org; Thu, 23 Jun 2016 03:29:27 -0400
Message-ID: <1466666961.26189.24.camel@redhat.com>
From: Gerd Hoffmann <kraxel@redhat.com>
Date: Thu, 23 Jun 2016 09:29:21 +0200
In-Reply-To: <1466634202-24616-3-git-send-email-samuel.thibault@ens-lyon.org>
References: <1466634202-24616-1-git-send-email-samuel.thibault@ens-lyon.org>
	<1466634202-24616-3-git-send-email-samuel.thibault@ens-lyon.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Mime-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 2/5] curses: Use cursesw when available
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Samuel Thibault <samuel.thibault@ens-lyon.org>
Cc: qemu-devel@nongnu.org, pbonzini@redhat.com, berrange@redhat.com, peter.maydell@linaro.org, mjt@tls.msk.ru

  Hi,

>  ##########################################
> +# cursesw probe
> +if test "$cursesw" !=3D "no" ; then
> +  if test "$mingw32" =3D "yes" ; then
> +    cursesw_inc_list=3D"$($pkg_config --cflags ncursesw 2>/dev/null):"
> +    cursesw_lib_list=3D"$($pkg_config --libs ncursesw 2>/dev/null):-lpdc=
urses"
> +  else
> +    cursesw_inc_list=3D"$($pkg_config --cflags ncursesw 2>/dev/null):"
> +    cursesw_lib_list=3D"$($pkg_config --libs ncursesw 2>/dev/null):-lncu=
rsesw:-lcursesw:-lncurses:-lcurses"
> +  fi
> [ ... ]

Do we *really* want this mess?

Is there any curses implementation without wide char support which is
still relevant today?

Is there any curses implementation beside ncurses still relevant today?

/me boots the freebsd guest.
/me finds libcurses being symlinks to libncurses.

I'm tempted to say just require ncursesw and be done with it.
That will also avoid the #ifdef mess in the following patches.

cheers,
  Gerd