From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38825) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bG621-0004B8-TV for qemu-devel@nongnu.org; Thu, 23 Jun 2016 10:55:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bG61u-0007Mq-O9 for qemu-devel@nongnu.org; Thu, 23 Jun 2016 10:55:00 -0400 Received: from mx1.redhat.com ([209.132.183.28]:58499) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bG61u-0007Mm-IH for qemu-devel@nongnu.org; Thu, 23 Jun 2016 10:54:54 -0400 From: Igor Mammedov Date: Thu, 23 Jun 2016 16:54:28 +0200 Message-Id: <1466693669-139967-11-git-send-email-imammedo@redhat.com> In-Reply-To: <1466693669-139967-1-git-send-email-imammedo@redhat.com> References: <1466693669-139967-1-git-send-email-imammedo@redhat.com> Subject: [Qemu-devel] [PATCH 10/11] pc: delay setting number of boot CPUs to machine_done time List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: pbonzini@redhat.com, rth@twiddle.net, ehabkost@redhat.com, mst@redhat.com, armbru@redhat.com, eduardo.otubo@profitbricks.com, zhugh.fnst@cn.fujitsu.com, eblake@redhat.com currently present CPUs counter in CMOS only contains smp_cpus (i.e. initial CPUs specified with -smp X) and doesn't account for CPUs created with -device. If VM is started with additional CPUs added with -device, it will hang in BIOS waiting for condition smp_cpus == counted_cpus forever as counted_cpus will include -device CPUs as well and be more than smp_cpus. make present CPUs counter in CMOS to count all CPUs (initial and coldplugged with -device) by delaying it to machine done time when it possible to count CPUs added with -device. Signed-off-by: Igor Mammedov --- hw/i386/pc.c | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/hw/i386/pc.c b/hw/i386/pc.c index b6b9acc..0b3baf0 100644 --- a/hw/i386/pc.c +++ b/hw/i386/pc.c @@ -471,9 +471,6 @@ void pc_cmos_init(PCMachineState *pcms, rtc_set_memory(s, 0x5c, val >> 8); rtc_set_memory(s, 0x5d, val >> 16); - /* set the number of CPU */ - rtc_set_memory(s, 0x5f, smp_cpus - 1); - object_property_add_link(OBJECT(pcms), "rtc_state", TYPE_ISA_DEVICE, (Object **)&pcms->rtc, @@ -1156,10 +1153,19 @@ void pc_cpus_init(PCMachineState *pcms) static void pc_machine_done(Notifier *notifier, void *data) { + int i, boot_cpus = 0; PCMachineState *pcms = container_of(notifier, PCMachineState, machine_done); PCIBus *bus = pcms->bus; + for (i = 0; i < pcms->possible_cpus->len; i++) { + if (pcms->possible_cpus->cpus[i].cpu) { + boot_cpus++; + } + } + /* set the number of CPUs */ + rtc_set_memory(pcms->rtc, 0x5f, boot_cpus - 1); + if (bus) { int extra_hosts = 0; -- 1.8.3.1