From: Igor Mammedov <imammedo@redhat.com>
To: qemu-devel@nongnu.org
Cc: pbonzini@redhat.com, rth@twiddle.net, ehabkost@redhat.com,
mst@redhat.com, armbru@redhat.com,
eduardo.otubo@profitbricks.com, zhugh.fnst@cn.fujitsu.com,
eblake@redhat.com
Subject: [Qemu-devel] [PATCH 06/11] target-i386: add socket/core/thread properties to X86CPU
Date: Thu, 23 Jun 2016 16:54:24 +0200 [thread overview]
Message-ID: <1466693669-139967-7-git-send-email-imammedo@redhat.com> (raw)
In-Reply-To: <1466693669-139967-1-git-send-email-imammedo@redhat.com>
these properties will be used by as address where to plug
CPU with help -device/device_add commands.
Signed-off-by: Igor Mammedov <imammedo@redhat.com>
---
hw/i386/pc.c | 12 ++++++++++++
target-i386/cpu.c | 3 +++
target-i386/cpu.h | 4 ++++
3 files changed, 19 insertions(+)
diff --git a/hw/i386/pc.c b/hw/i386/pc.c
index 6ba6343..87352ae 100644
--- a/hw/i386/pc.c
+++ b/hw/i386/pc.c
@@ -1775,6 +1775,18 @@ static void pc_cpu_pre_plug(HotplugHandler *hotplug_dev,
cpu->apic_id);
return;
}
+
+ /* set 'address' properties socket/core/thread for initial and cpu-add
+ * added CPUs so that query_hotpluggable_cpus would show correct values
+ */
+ if (cpu->thread == -1 || cpu->core == -1 || cpu->socket == -1) {
+ X86CPUTopoInfo topo;
+
+ x86_topo_ids_from_apicid(cpu->apic_id, smp_cores, smp_threads, &topo);
+ cpu->thread = topo.smt_id;
+ cpu->core = topo.core_id;
+ cpu->socket = topo.pkg_id;
+ }
}
static void pc_machine_device_pre_plug_cb(HotplugHandler *hotplug_dev,
diff --git a/target-i386/cpu.c b/target-i386/cpu.c
index 9294b3d..8c651f2 100644
--- a/target-i386/cpu.c
+++ b/target-i386/cpu.c
@@ -3186,6 +3186,9 @@ static Property x86_cpu_properties[] = {
DEFINE_PROP_UINT32("xlevel2", X86CPU, env.cpuid_xlevel2, 0),
DEFINE_PROP_STRING("hv-vendor-id", X86CPU, hyperv_vendor_id),
DEFINE_PROP_BOOL("cpuid-0xb", X86CPU, enable_cpuid_0xb, true),
+ DEFINE_PROP_INT32("thread", X86CPU, thread, -1),
+ DEFINE_PROP_INT32("core", X86CPU, core, -1),
+ DEFINE_PROP_INT32("socket", X86CPU, socket, -1),
DEFINE_PROP_END_OF_LIST()
};
diff --git a/target-i386/cpu.h b/target-i386/cpu.h
index 8b09cfa..a04d334 100644
--- a/target-i386/cpu.h
+++ b/target-i386/cpu.h
@@ -1190,6 +1190,10 @@ struct X86CPU {
Notifier machine_done;
struct kvm_msrs *kvm_msr_buf;
+
+ int32_t socket;
+ int32_t core;
+ int32_t thread;
};
static inline X86CPU *x86_env_get_cpu(CPUX86State *env)
--
1.8.3.1
next prev parent reply other threads:[~2016-06-23 14:54 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-23 14:54 [Qemu-devel] [PATCH 00/11] pc: allow to use -device/device_add for CPUs Igor Mammedov
2016-06-23 14:54 ` [Qemu-devel] [PATCH 01/11] target-i386: cpu: use uint32_t for X86CPU.apic_id Igor Mammedov
2016-06-23 14:54 ` [Qemu-devel] [PATCH 02/11] pc: add x86_topo_ids_from_apicid() Igor Mammedov
2016-06-23 14:54 ` [Qemu-devel] [PATCH 03/11] pc: extract CPU lookup into a separate function Igor Mammedov
2016-06-23 17:32 ` Eduardo Habkost
2016-06-23 17:41 ` Igor Mammedov
2016-06-23 14:54 ` [Qemu-devel] [PATCH 04/11] pc: cpu: consolidate apic-id validity checks in pc_cpu_pre_plug() Igor Mammedov
2016-06-23 14:54 ` [Qemu-devel] [PATCH 05/11] target-i386: cpu: replace custom apic-id setter/getter with static property Igor Mammedov
2016-06-27 17:55 ` Eduardo Habkost
2016-06-28 6:43 ` Igor Mammedov
2016-06-28 13:35 ` Eduardo Habkost
2016-06-23 14:54 ` Igor Mammedov [this message]
2016-06-23 17:44 ` [Qemu-devel] [PATCH 06/11] target-i386: add socket/core/thread properties to X86CPU Eduardo Habkost
2016-06-23 19:18 ` Igor Mammedov
2016-06-23 20:18 ` Eduardo Habkost
2016-06-23 20:46 ` Igor Mammedov
2016-06-23 21:43 ` Eduardo Habkost
2016-06-24 5:23 ` Igor Mammedov
2016-06-23 14:54 ` [Qemu-devel] [PATCH 07/11] pc: set APIC ID based on socket/core/thread ids if it's not been set yet Igor Mammedov
2016-06-23 17:19 ` Eduardo Habkost
2016-06-23 17:48 ` Igor Mammedov
2016-06-23 19:27 ` Eduardo Habkost
2016-06-23 20:50 ` Igor Mammedov
2016-06-23 14:54 ` [Qemu-devel] [PATCH 08/11] pc: implement query-hotpluggable-cpus callback Igor Mammedov
2016-06-23 14:54 ` [Qemu-devel] [PATCH 09/11] pc: register created initial and hotpluged CPUs in one place pc_cpu_plug() Igor Mammedov
2016-06-23 14:54 ` [Qemu-devel] [PATCH 10/11] pc: delay setting number of boot CPUs to machine_done time Igor Mammedov
2016-06-23 14:54 ` [Qemu-devel] [PATCH 11/11] pc: cpu: allow device_add to be used with x86 cpu Igor Mammedov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1466693669-139967-7-git-send-email-imammedo@redhat.com \
--to=imammedo@redhat.com \
--cc=armbru@redhat.com \
--cc=eblake@redhat.com \
--cc=eduardo.otubo@profitbricks.com \
--cc=ehabkost@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
--cc=zhugh.fnst@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).