From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39516) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bG650-00079u-7s for qemu-devel@nongnu.org; Thu, 23 Jun 2016 10:58:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bG64u-0007s5-5M for qemu-devel@nongnu.org; Thu, 23 Jun 2016 10:58:05 -0400 Received: from mx1.redhat.com ([209.132.183.28]:59590) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bG64t-0007rz-S2 for qemu-devel@nongnu.org; Thu, 23 Jun 2016 10:58:00 -0400 Message-ID: <1466693874.26189.50.camel@redhat.com> From: Gerd Hoffmann Date: Thu, 23 Jun 2016 16:57:54 +0200 In-Reply-To: <20160622150937.GS5666@perard.uk.xensource.com> References: <20160622150937.GS5666@perard.uk.xensource.com> Content-Type: multipart/mixed; boundary="=-muIVp2Ys8hN+0nW2CGE/" Mime-Version: 1.0 Subject: Re: [Qemu-devel] Change of max-ram-below-4g initial value breaks Xen List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony PERARD Cc: qemu-devel@nongnu.org, xen-devel@lists.xen.org, Stefano Stabellini , Paolo Bonzini --=-muIVp2Ys8hN+0nW2CGE/ Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi, > How could xen_ram_init() find out if the value of max-ram-below-4g is > the default or if a user have set it? Is there another way we could fix > this? Attached patch should fix it. Patch survived a quick smoke test on kvm so far, need to do some more testing tomorrow. Can you give it a spin on xen? thanks, Gerd --=-muIVp2Ys8hN+0nW2CGE/ Content-Disposition: attachment; filename="0001-xen-fix-ram-init-regression.patch" Content-Type: text/x-patch; name="0001-xen-fix-ram-init-regression.patch"; charset="UTF-8" Content-Transfer-Encoding: base64 RnJvbSBkNDVhOTU4NjFkZWYxOGEwMmUxYzI2ZDM3MTc2OTM0MzI1MTcxMDdhIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBHZXJkIEhvZmZtYW5uIDxrcmF4ZWxAcmVkaGF0LmNvbT4KRGF0 ZTogVGh1LCAyMyBKdW4gMjAxNiAxNjo0OTowMyArMDIwMApTdWJqZWN0OiBbUEFUQ0hdIHhlbjog Zml4IHJhbSBpbml0IHJlZ3Jlc3Npb24KCkNvbW1pdCAiODE1NmQ0OCBwYzogYWxsb3cgcmFpc2lu ZyBsb3cgbWVtb3J5IHZpYSBtYXgtcmFtLWJlbG93LTRnCm9wdGlvbiIgY2F1c2VzIGEgcmVncmVz c2lvbiBvbiB4ZW4sIGJlY2F1c2UgaXQgdXNlcyBhIGRpZmZlcmVudAptZW1vcnkgc3BsaXQuCgpU aGlzIHBhdGNoIGluaXRpYWxpemVzIG1heC1yYW0tYmVsb3ctNGcgdG8gemVybyBhbmQgbGVhdmVz IHRoZQppbml0aWFsaXphdGlvbiB0byB0aGUgbWVtb3J5IGluaXRpYWxpemF0aW9uIGZ1bmN0aW9u cy4gIFRoYXQgd2F5CnRoZXkgY2FuIHBpY2sgZGlmZmVyZW50IGRlZmF1bHQgdmFsdWVzIChtYXgt cmFtLWJlbG93LTRnIGlzIHplcm8Kc3RpbGwpIG9yIHVzZSB0aGUgdXNlciBzdXBwbGllZCB2YWx1 ZSAobWF4LXJhbS1iZWxvdy00ZyBpcyBub24temVybykuCgpTaWduZWQtb2ZmLWJ5OiBHZXJkIEhv ZmZtYW5uIDxrcmF4ZWxAcmVkaGF0LmNvbT4KLS0tCiBody9pMzg2L3BjLmMgICAgICB8IDIgKy0K IGh3L2kzODYvcGNfcGlpeC5jIHwgMyArKysKIGh3L2kzODYvcGNfcTM1LmMgIHwgMyArKysKIHhl bi1odm0uYyAgICAgICAgIHwgMyArKysKIDQgZmlsZXMgY2hhbmdlZCwgMTAgaW5zZXJ0aW9ucygr KSwgMSBkZWxldGlvbigtKQoKZGlmZiAtLWdpdCBhL2h3L2kzODYvcGMuYyBiL2h3L2kzODYvcGMu YwppbmRleCA3MTk4ZWQ1Li42NmUxZGFlIDEwMDY0NAotLS0gYS9ody9pMzg2L3BjLmMKKysrIGIv aHcvaTM4Ni9wYy5jCkBAIC0xODg2LDcgKzE4ODYsNyBAQCBzdGF0aWMgdm9pZCBwY19tYWNoaW5l X2luaXRmbihPYmplY3QgKm9iaikKICAgICAgICAgICAgICAgICAgICAgICAgIHBjX21hY2hpbmVf Z2V0X2hvdHBsdWdfbWVtb3J5X3JlZ2lvbl9zaXplLAogICAgICAgICAgICAgICAgICAgICAgICAg TlVMTCwgTlVMTCwgTlVMTCwgJmVycm9yX2Fib3J0KTsKIAotICAgIHBjbXMtPm1heF9yYW1fYmVs b3dfNGcgPSAweGUwMDAwMDAwOyAvKiAzLjVHICovCisgICAgcGNtcy0+bWF4X3JhbV9iZWxvd180 ZyA9IDA7IC8qIHVzZSBkZWZhdWx0ICovCiAgICAgb2JqZWN0X3Byb3BlcnR5X2FkZChvYmosIFBD X01BQ0hJTkVfTUFYX1JBTV9CRUxPV180RywgInNpemUiLAogICAgICAgICAgICAgICAgICAgICAg ICAgcGNfbWFjaGluZV9nZXRfbWF4X3JhbV9iZWxvd180ZywKICAgICAgICAgICAgICAgICAgICAg ICAgIHBjX21hY2hpbmVfc2V0X21heF9yYW1fYmVsb3dfNGcsCmRpZmYgLS1naXQgYS9ody9pMzg2 L3BjX3BpaXguYyBiL2h3L2kzODYvcGNfcGlpeC5jCmluZGV4IDUzYmM5NjguLjc4ZTNkNDQgMTAw NjQ0Ci0tLSBhL2h3L2kzODYvcGNfcGlpeC5jCisrKyBiL2h3L2kzODYvcGNfcGlpeC5jCkBAIC0x MTQsNiArMTE0LDkgQEAgc3RhdGljIHZvaWQgcGNfaW5pdDEoTWFjaGluZVN0YXRlICptYWNoaW5l LAogICAgICAqICAgIHFlbXUgLU0gcGMsbWF4LXJhbS1iZWxvdy00Zz0yRyAtbSA0RyAgICAgLT4g MjA0OE0gbG93LCAyMDQ4TSBoaWdoCiAgICAgICogICAgcWVtdSAtTSBwYyxtYXgtcmFtLWJlbG93 LTRnPTRHIC1tIDM5NjhNICAtPiAzOTY4TSBsb3cgKD00Ry0xMjhNKQogICAgICAqLworICAgIGlm ICghcGNtcy0+bWF4X3JhbV9iZWxvd180ZykgeworICAgICAgICBwY21zLT5tYXhfcmFtX2JlbG93 XzRnID0gMHhlMDAwMDAwMDsgLyogZGVmYXVsdDogMy41RyAqLworICAgIH0KICAgICBsb3dtZW0g PSBwY21zLT5tYXhfcmFtX2JlbG93XzRnOwogICAgIGlmIChtYWNoaW5lLT5yYW1fc2l6ZSA+PSBw Y21zLT5tYXhfcmFtX2JlbG93XzRnKSB7CiAgICAgICAgIGlmIChwY21jLT5naWdhYnl0ZV9hbGln bikgewpkaWZmIC0tZ2l0IGEvaHcvaTM4Ni9wY19xMzUuYyBiL2h3L2kzODYvcGNfcTM1LmMKaW5k ZXggZTRiNTQxZi4uMWI2NTNlMiAxMDA2NDQKLS0tIGEvaHcvaTM4Ni9wY19xMzUuYworKysgYi9o dy9pMzg2L3BjX3EzNS5jCkBAIC05Myw2ICs5Myw5IEBAIHN0YXRpYyB2b2lkIHBjX3EzNV9pbml0 KE1hY2hpbmVTdGF0ZSAqbWFjaGluZSkKICAgICAvKiBIYW5kbGUgdGhlIG1hY2hpbmUgb3B0IG1h eC1yYW0tYmVsb3ctNGcuICBJdCBpcyBiYXNpY2FsbHkgZG9pbmcKICAgICAgKiBtaW4ocWVtdSBs aW1pdCwgdXNlciBsaW1pdCkuCiAgICAgICovCisgICAgaWYgKCFwY21zLT5tYXhfcmFtX2JlbG93 XzRnKSB7CisgICAgICAgIHBjbXMtPm1heF9yYW1fYmVsb3dfNGcgPSAxVUxMIDw8IDMyOyAvKiBk ZWZhdWx0OiA0RyAqLzsKKyAgICB9CiAgICAgaWYgKGxvd21lbSA+IHBjbXMtPm1heF9yYW1fYmVs b3dfNGcpIHsKICAgICAgICAgbG93bWVtID0gcGNtcy0+bWF4X3JhbV9iZWxvd180ZzsKICAgICAg ICAgaWYgKG1hY2hpbmUtPnJhbV9zaXplIC0gbG93bWVtID4gbG93bWVtICYmCmRpZmYgLS1naXQg YS94ZW4taHZtLmMgYi94ZW4taHZtLmMKaW5kZXggOThlYTQ0Zi4uZWI1Nzc5MiAxMDA2NDQKLS0t IGEveGVuLWh2bS5jCisrKyBiL3hlbi1odm0uYwpAQCAtMTkwLDYgKzE5MCw5IEBAIHN0YXRpYyB2 b2lkIHhlbl9yYW1faW5pdChQQ01hY2hpbmVTdGF0ZSAqcGNtcywKICAgICAvKiBIYW5kbGUgdGhl IG1hY2hpbmUgb3B0IG1heC1yYW0tYmVsb3ctNGcuICBJdCBpcyBiYXNpY2FsbHkgZG9pbmcKICAg ICAgKiBtaW4oeGVuIGxpbWl0LCB1c2VyIGxpbWl0KS4KICAgICAgKi8KKyAgICBpZiAoIXVzZXJf bG93bWVtKSB7CisgICAgICAgIHVzZXJfbG93bWVtID0gSFZNX0JFTE9XXzRHX1JBTV9FTkQ7IC8q IGRlZmF1bHQgKi8KKyAgICB9CiAgICAgaWYgKEhWTV9CRUxPV180R19SQU1fRU5EIDw9IHVzZXJf bG93bWVtKSB7CiAgICAgICAgIHVzZXJfbG93bWVtID0gSFZNX0JFTE9XXzRHX1JBTV9FTkQ7CiAg ICAgfQotLSAKMS44LjMuMQoK --=-muIVp2Ys8hN+0nW2CGE/--