From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51032) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bGJwk-0000dv-ON for qemu-devel@nongnu.org; Fri, 24 Jun 2016 01:46:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bGJwg-00044j-JW for qemu-devel@nongnu.org; Fri, 24 Jun 2016 01:46:29 -0400 Received: from mx1.redhat.com ([209.132.183.28]:57059) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bGJwg-00044c-B7 for qemu-devel@nongnu.org; Fri, 24 Jun 2016 01:46:26 -0400 Message-ID: <1466747183.16435.1.camel@redhat.com> From: Gerd Hoffmann Date: Fri, 24 Jun 2016 07:46:23 +0200 In-Reply-To: <20160623161847.GT5666@perard.uk.xensource.com> References: <20160622150937.GS5666@perard.uk.xensource.com> <1466693874.26189.50.camel@redhat.com> <20160623161847.GT5666@perard.uk.xensource.com> Content-Type: multipart/mixed; boundary="=-5BQcJ/zRg+kICs25wt4j" Mime-Version: 1.0 Subject: Re: [Qemu-devel] Change of max-ram-below-4g initial value breaks Xen List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony PERARD Cc: qemu-devel@nongnu.org, xen-devel@lists.xen.org, Stefano Stabellini , Paolo Bonzini --=-5BQcJ/zRg+kICs25wt4j Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Do, 2016-06-23 at 17:18 +0100, Anthony PERARD wrote: > On Thu, Jun 23, 2016 at 04:57:54PM +0200, Gerd Hoffmann wrote: > > Hi, > >=20 > > > How could xen_ram_init() find out if the value of max-ram-below-4g is > > > the default or if a user have set it? Is there another way we could f= ix > > > this? > >=20 > > Attached patch should fix it. Patch survived a quick smoke test on kvm > > so far, need to do some more testing tomorrow. Can you give it a spin > > on xen? >=20 > Thanks. Unfortunately, it does not work :(. >=20 > In this patch, max_ram_below_4g is set before the call to xen_ram_init() > and xen_ram_init read it back (via object_property_get_int()). So, in > xen_ram_init, user_lowmem is not 0. Ah, I see. We do the split calculation twice on xen. That is pretty pointless. New patch attached. cheers, Gerd --=-5BQcJ/zRg+kICs25wt4j Content-Disposition: attachment; filename="0001-xen-fix-ram-init-regression.patch" Content-Type: text/x-patch; name="0001-xen-fix-ram-init-regression.patch"; charset="UTF-8" Content-Transfer-Encoding: base64 RnJvbSBhMWJiMGQ0ZjdhOTRlOTcxMDJlN2VhNzJkMGE2NWRlMmExN2IxMTYwIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBHZXJkIEhvZmZtYW5uIDxrcmF4ZWxAcmVkaGF0LmNvbT4KRGF0 ZTogVGh1LCAyMyBKdW4gMjAxNiAxNjo0OTowMyArMDIwMApTdWJqZWN0OiBbUEFUQ0hdIHhlbjog Zml4IHJhbSBpbml0IHJlZ3Jlc3Npb24KCkNvbW1pdCAiODE1NmQ0OCBwYzogYWxsb3cgcmFpc2lu ZyBsb3cgbWVtb3J5IHZpYSBtYXgtcmFtLWJlbG93LTRnCm9wdGlvbiIgY2F1c2VzIGEgcmVncmVz c2lvbiBvbiB4ZW4sIGJlY2F1c2UgaXQgdXNlcyBhIGRpZmZlcmVudAptZW1vcnkgc3BsaXQuCgpU aGlzIHBhdGNoIGluaXRpYWxpemVzIG1heC1yYW0tYmVsb3ctNGcgdG8gemVybyBhbmQgbGVhdmVz IHRoZQppbml0aWFsaXphdGlvbiB0byB0aGUgbWVtb3J5IGluaXRpYWxpemF0aW9uIGZ1bmN0aW9u cy4gIFRoYXQgd2F5CnRoZXkgY2FuIHBpY2sgZGlmZmVyZW50IGRlZmF1bHQgdmFsdWVzIChtYXgt cmFtLWJlbG93LTRnIGlzIHplcm8Kc3RpbGwpIG9yIHVzZSB0aGUgdXNlciBzdXBwbGllZCB2YWx1 ZSAobWF4LXJhbS1iZWxvdy00ZyBpcyBub24temVybykuCgpBbHNvIHNraXAgdGhlIHdob2xlIHJh bSBzcGxpdCBjYWxjdWxhdGlvbiBvbiBYZW4uICB4ZW5fcmFtX2luaXQoKQpkb2VzIGl0cyBvd24g c3BsaXQgY2FsY3VsYXRpb24gYW55d2F5IHNvIGl0IGlzIHN1cGVyZmx1b3VzLCBhbHNvCnRoaXMg d2F5IHhlbl9yYW1faW5pdCBjYW4gYWN0dWFsbHkgc2VlIHdoZW5ldmVyIG1heC1yYW0tYmVsb3ct NGcKaXMgemVybyBvciBub3QuCgpTaWduZWQtb2ZmLWJ5OiBHZXJkIEhvZmZtYW5uIDxrcmF4ZWxA cmVkaGF0LmNvbT4KLS0tCiBody9pMzg2L3BjLmMgICAgICB8ICAyICstCiBody9pMzg2L3BjX3Bp aXguYyB8IDUyICsrKysrKysrKysrKysrKysrKysrKysrKysrKysrLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0KIGh3L2kzODYvcGNfcTM1LmMgIHwgIDMgKysrCiB4ZW4taHZtLmMgICAgICAgICB8ICAz ICsrKwogNCBmaWxlcyBjaGFuZ2VkLCAzNiBpbnNlcnRpb25zKCspLCAyNCBkZWxldGlvbnMoLSkK CmRpZmYgLS1naXQgYS9ody9pMzg2L3BjLmMgYi9ody9pMzg2L3BjLmMKaW5kZXggNzE5OGVkNS4u NjZlMWRhZSAxMDA2NDQKLS0tIGEvaHcvaTM4Ni9wYy5jCisrKyBiL2h3L2kzODYvcGMuYwpAQCAt MTg4Niw3ICsxODg2LDcgQEAgc3RhdGljIHZvaWQgcGNfbWFjaGluZV9pbml0Zm4oT2JqZWN0ICpv YmopCiAgICAgICAgICAgICAgICAgICAgICAgICBwY19tYWNoaW5lX2dldF9ob3RwbHVnX21lbW9y eV9yZWdpb25fc2l6ZSwKICAgICAgICAgICAgICAgICAgICAgICAgIE5VTEwsIE5VTEwsIE5VTEws ICZlcnJvcl9hYm9ydCk7CiAKLSAgICBwY21zLT5tYXhfcmFtX2JlbG93XzRnID0gMHhlMDAwMDAw MDsgLyogMy41RyAqLworICAgIHBjbXMtPm1heF9yYW1fYmVsb3dfNGcgPSAwOyAvKiB1c2UgZGVm YXVsdCAqLwogICAgIG9iamVjdF9wcm9wZXJ0eV9hZGQob2JqLCBQQ19NQUNISU5FX01BWF9SQU1f QkVMT1dfNEcsICJzaXplIiwKICAgICAgICAgICAgICAgICAgICAgICAgIHBjX21hY2hpbmVfZ2V0 X21heF9yYW1fYmVsb3dfNGcsCiAgICAgICAgICAgICAgICAgICAgICAgICBwY19tYWNoaW5lX3Nl dF9tYXhfcmFtX2JlbG93XzRnLApkaWZmIC0tZ2l0IGEvaHcvaTM4Ni9wY19waWl4LmMgYi9ody9p Mzg2L3BjX3BpaXguYwppbmRleCA1M2JjOTY4Li5mNTFmYTc3IDEwMDY0NAotLS0gYS9ody9pMzg2 L3BjX3BpaXguYworKysgYi9ody9pMzg2L3BjX3BpaXguYwpAQCAtMTA4LDM3ICsxMDgsNDMgQEAg c3RhdGljIHZvaWQgcGNfaW5pdDEoTWFjaGluZVN0YXRlICptYWNoaW5lLAogICAgICAqICAgIHNv IGxlZ2FjeSBub24tUEFFIGd1ZXN0cyBjYW4gZ2V0IGFzIG11Y2ggbWVtb3J5IGFzIHBvc3NpYmxl IGluCiAgICAgICogICAgdGhlIDMyYml0IGFkZHJlc3Mgc3BhY2UgYmVsb3cgNEcuCiAgICAgICoK KyAgICAgKiAgLSBOb3RlIHRoYXQgWGVuIGhhcyBpdHMgb3duIHJhbSBzZXRwIGNvZGUgaW4geGVu X3JhbV9pbml0KCksCisgICAgICogICAgY2FsbGVkIHZpYSB4ZW5faHZtX2luaXQoKS4KKyAgICAg KgogICAgICAqIEV4YW1wbGVzOgogICAgICAqICAgIHFlbXUgLU0gcGMtMS43IC1tIDRHICAgIChv bGQgZGVmYXVsdCkgICAgLT4gMzU4NE0gbG93LCAgNTEyTSBoaWdoCiAgICAgICogICAgcWVtdSAt TSBwYyAtbSA0RyAgICAgICAgKG5ldyBkZWZhdWx0KSAgICAtPiAzMDcyTSBsb3csIDEwMjRNIGhp Z2gKICAgICAgKiAgICBxZW11IC1NIHBjLG1heC1yYW0tYmVsb3ctNGc9MkcgLW0gNEcgICAgIC0+ IDIwNDhNIGxvdywgMjA0OE0gaGlnaAogICAgICAqICAgIHFlbXUgLU0gcGMsbWF4LXJhbS1iZWxv dy00Zz00RyAtbSAzOTY4TSAgLT4gMzk2OE0gbG93ICg9NEctMTI4TSkKICAgICAgKi8KLSAgICBs b3dtZW0gPSBwY21zLT5tYXhfcmFtX2JlbG93XzRnOwotICAgIGlmIChtYWNoaW5lLT5yYW1fc2l6 ZSA+PSBwY21zLT5tYXhfcmFtX2JlbG93XzRnKSB7Ci0gICAgICAgIGlmIChwY21jLT5naWdhYnl0 ZV9hbGlnbikgewotICAgICAgICAgICAgaWYgKGxvd21lbSA+IDB4YzAwMDAwMDApIHsKLSAgICAg ICAgICAgICAgICBsb3dtZW0gPSAweGMwMDAwMDAwOwotICAgICAgICAgICAgfQotICAgICAgICAg ICAgaWYgKGxvd21lbSAmICgoMVVMTCA8PCAzMCkgLSAxKSkgewotICAgICAgICAgICAgICAgIGVy cm9yX3JlcG9ydCgiV2FybmluZzogTGFyZ2UgbWFjaGluZSBhbmQgbWF4X3JhbV9iZWxvd180ZyAi Ci0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICIoJSIgUFJJdTY0ICIpIG5vdCBhIG11bHRp cGxlIG9mIDFHOyAiCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICJwb3NzaWJsZSBiYWQg cGVyZm9ybWFuY2UuIiwKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgcGNtcy0+bWF4X3Jh bV9iZWxvd180Zyk7Ci0gICAgICAgICAgICB9Ci0gICAgICAgIH0KLSAgICB9Ci0KLSAgICBpZiAo bWFjaGluZS0+cmFtX3NpemUgPj0gbG93bWVtKSB7Ci0gICAgICAgIHBjbXMtPmFib3ZlXzRnX21l bV9zaXplID0gbWFjaGluZS0+cmFtX3NpemUgLSBsb3dtZW07Ci0gICAgICAgIHBjbXMtPmJlbG93 XzRnX21lbV9zaXplID0gbG93bWVtOwotICAgIH0gZWxzZSB7Ci0gICAgICAgIHBjbXMtPmFib3Zl XzRnX21lbV9zaXplID0gMDsKLSAgICAgICAgcGNtcy0+YmVsb3dfNGdfbWVtX3NpemUgPSBtYWNo aW5lLT5yYW1fc2l6ZTsKLSAgICB9Ci0KICAgICBpZiAoeGVuX2VuYWJsZWQoKSkgewogICAgICAg ICB4ZW5faHZtX2luaXQocGNtcywgJnJhbV9tZW1vcnkpOworICAgIH0gZWxzZSB7CisgICAgICAg IGlmICghcGNtcy0+bWF4X3JhbV9iZWxvd180ZykgeworICAgICAgICAgICAgcGNtcy0+bWF4X3Jh bV9iZWxvd180ZyA9IDB4ZTAwMDAwMDA7IC8qIGRlZmF1bHQ6IDMuNUcgKi8KKyAgICAgICAgfQor ICAgICAgICBsb3dtZW0gPSBwY21zLT5tYXhfcmFtX2JlbG93XzRnOworICAgICAgICBpZiAobWFj aGluZS0+cmFtX3NpemUgPj0gcGNtcy0+bWF4X3JhbV9iZWxvd180ZykgeworICAgICAgICAgICAg aWYgKHBjbWMtPmdpZ2FieXRlX2FsaWduKSB7CisgICAgICAgICAgICAgICAgaWYgKGxvd21lbSA+ IDB4YzAwMDAwMDApIHsKKyAgICAgICAgICAgICAgICAgICAgbG93bWVtID0gMHhjMDAwMDAwMDsK KyAgICAgICAgICAgICAgICB9CisgICAgICAgICAgICAgICAgaWYgKGxvd21lbSAmICgoMVVMTCA8 PCAzMCkgLSAxKSkgeworICAgICAgICAgICAgICAgICAgICBlcnJvcl9yZXBvcnQoIldhcm5pbmc6 IExhcmdlIG1hY2hpbmUgYW5kIG1heF9yYW1fYmVsb3dfNGcgIgorICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgIiglIiBQUkl1NjQgIikgbm90IGEgbXVsdGlwbGUgb2YgMUc7ICIKKyAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICJwb3NzaWJsZSBiYWQgcGVyZm9ybWFuY2Uu IiwKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHBjbXMtPm1heF9yYW1fYmVsb3df NGcpOworICAgICAgICAgICAgICAgIH0KKyAgICAgICAgICAgIH0KKyAgICAgICAgfQorCisgICAg ICAgIGlmIChtYWNoaW5lLT5yYW1fc2l6ZSA+PSBsb3dtZW0pIHsKKyAgICAgICAgICAgIHBjbXMt PmFib3ZlXzRnX21lbV9zaXplID0gbWFjaGluZS0+cmFtX3NpemUgLSBsb3dtZW07CisgICAgICAg ICAgICBwY21zLT5iZWxvd180Z19tZW1fc2l6ZSA9IGxvd21lbTsKKyAgICAgICAgfSBlbHNlIHsK KyAgICAgICAgICAgIHBjbXMtPmFib3ZlXzRnX21lbV9zaXplID0gMDsKKyAgICAgICAgICAgIHBj bXMtPmJlbG93XzRnX21lbV9zaXplID0gbWFjaGluZS0+cmFtX3NpemU7CisgICAgICAgIH0KICAg ICB9CiAKICAgICBwY19jcHVzX2luaXQocGNtcyk7CmRpZmYgLS1naXQgYS9ody9pMzg2L3BjX3Ez NS5jIGIvaHcvaTM4Ni9wY19xMzUuYwppbmRleCBlNGI1NDFmLi4xYjY1M2UyIDEwMDY0NAotLS0g YS9ody9pMzg2L3BjX3EzNS5jCisrKyBiL2h3L2kzODYvcGNfcTM1LmMKQEAgLTkzLDYgKzkzLDkg QEAgc3RhdGljIHZvaWQgcGNfcTM1X2luaXQoTWFjaGluZVN0YXRlICptYWNoaW5lKQogICAgIC8q IEhhbmRsZSB0aGUgbWFjaGluZSBvcHQgbWF4LXJhbS1iZWxvdy00Zy4gIEl0IGlzIGJhc2ljYWxs eSBkb2luZwogICAgICAqIG1pbihxZW11IGxpbWl0LCB1c2VyIGxpbWl0KS4KICAgICAgKi8KKyAg ICBpZiAoIXBjbXMtPm1heF9yYW1fYmVsb3dfNGcpIHsKKyAgICAgICAgcGNtcy0+bWF4X3JhbV9i ZWxvd180ZyA9IDFVTEwgPDwgMzI7IC8qIGRlZmF1bHQ6IDRHICovOworICAgIH0KICAgICBpZiAo bG93bWVtID4gcGNtcy0+bWF4X3JhbV9iZWxvd180ZykgewogICAgICAgICBsb3dtZW0gPSBwY21z LT5tYXhfcmFtX2JlbG93XzRnOwogICAgICAgICBpZiAobWFjaGluZS0+cmFtX3NpemUgLSBsb3dt ZW0gPiBsb3dtZW0gJiYKZGlmZiAtLWdpdCBhL3hlbi1odm0uYyBiL3hlbi1odm0uYwppbmRleCA5 OGVhNDRmLi5lYjU3NzkyIDEwMDY0NAotLS0gYS94ZW4taHZtLmMKKysrIGIveGVuLWh2bS5jCkBA IC0xOTAsNiArMTkwLDkgQEAgc3RhdGljIHZvaWQgeGVuX3JhbV9pbml0KFBDTWFjaGluZVN0YXRl ICpwY21zLAogICAgIC8qIEhhbmRsZSB0aGUgbWFjaGluZSBvcHQgbWF4LXJhbS1iZWxvdy00Zy4g IEl0IGlzIGJhc2ljYWxseSBkb2luZwogICAgICAqIG1pbih4ZW4gbGltaXQsIHVzZXIgbGltaXQp LgogICAgICAqLworICAgIGlmICghdXNlcl9sb3dtZW0pIHsKKyAgICAgICAgdXNlcl9sb3dtZW0g PSBIVk1fQkVMT1dfNEdfUkFNX0VORDsgLyogZGVmYXVsdCAqLworICAgIH0KICAgICBpZiAoSFZN X0JFTE9XXzRHX1JBTV9FTkQgPD0gdXNlcl9sb3dtZW0pIHsKICAgICAgICAgdXNlcl9sb3dtZW0g PSBIVk1fQkVMT1dfNEdfUkFNX0VORDsKICAgICB9Ci0tIAoxLjguMy4xCgo= --=-5BQcJ/zRg+kICs25wt4j--