From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56936) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bGTMl-0001ds-Jq for qemu-devel@nongnu.org; Fri, 24 Jun 2016 11:50:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bGTMj-0004Mg-NE for qemu-devel@nongnu.org; Fri, 24 Jun 2016 11:49:58 -0400 From: Peter Maydell Date: Fri, 24 Jun 2016 16:49:40 +0100 Message-Id: <1466783381-29506-2-git-send-email-peter.maydell@linaro.org> In-Reply-To: <1466783381-29506-1-git-send-email-peter.maydell@linaro.org> References: <1466783381-29506-1-git-send-email-peter.maydell@linaro.org> Subject: [Qemu-devel] [PATCH 1/2] linux-user: Make semihosting heap/stack fields abi_ulongs List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-arm@nongnu.org, qemu-devel@nongnu.org Cc: patches@linaro.org, Tsung-Han Lin , Laurent Desnogues The fields in the TaskState heap_base, heap_limit and stack_base are all guest addresses (representing the locations of the heap and stack for the guest binary), so they should be abi_ulong rather than uint32_t. (This only in practice affects ARM AArch64 since all the other semihosting implementations are 32-bit.) Signed-off-by: Peter Maydell --- linux-user/qemu.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/linux-user/qemu.h b/linux-user/qemu.h index 56f29c3..1b3b03b 100644 --- a/linux-user/qemu.h +++ b/linux-user/qemu.h @@ -111,10 +111,10 @@ typedef struct TaskState { #endif #if defined(TARGET_ARM) || defined(TARGET_M68K) || defined(TARGET_UNICORE32) /* Extra fields for semihosted binaries. */ - uint32_t heap_base; - uint32_t heap_limit; + abi_ulong heap_base; + abi_ulong heap_limit; #endif - uint32_t stack_base; + abi_ulong stack_base; int used; /* non zero if used */ struct image_info *info; struct linux_binprm *bprm; -- 1.9.1