qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Leon Alrae <leon.alrae@imgtec.com>
To: qemu-devel@nongnu.org
Cc: Aleksandar Markovic <aleksandar.markovic@imgtec.com>
Subject: [Qemu-devel] [PULL 06/10] target-mips: Activate IEEE 754-2008 signaling NaN bit meaning for MSA
Date: Sun, 26 Jun 2016 14:38:38 +0100	[thread overview]
Message-ID: <1466948322-27138-7-git-send-email-leon.alrae@imgtec.com> (raw)
In-Reply-To: <1466948322-27138-1-git-send-email-leon.alrae@imgtec.com>

From: Aleksandar Markovic <aleksandar.markovic@imgtec.com>

Function msa_reset() is updated so that flag snan_bit_is_one is
properly set to 0.

By applying this patch, a number of incorrect MSA behaviors that
require IEEE 754-2008 compliance will be fixed. Those are behaviors
that (up to the moment of applying this patch) did not get the desired
functionality from SoftFloat library with respect to distinguishing
between quiet and signaling NaN, getting default NaN values (both
quiet and signaling), establishing if a floating point number is NaN
or not, etc.

Two examples:

* FMAX, FMIN will now correctly detect and propagate NaNs.
* FCLASS.D ans FCLASS.S will now correcty detect NaN flavors.

Signed-off-by: Aleksandar Markovic <aleksandar.markovic@imgtec.com>
Reviewed-by: Leon Alrae <leon.alrae@imgtec.com>
Signed-off-by: Leon Alrae <leon.alrae@imgtec.com>
---
 target-mips/translate_init.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/target-mips/translate_init.c b/target-mips/translate_init.c
index e81a831..a37d8bb 100644
--- a/target-mips/translate_init.c
+++ b/target-mips/translate_init.c
@@ -893,5 +893,6 @@ static void msa_reset(CPUMIPSState *env)
     /* clear float_status nan mode */
     set_default_nan_mode(0, &env->active_tc.msa_fp_status);
 
-    set_snan_bit_is_one(1, &env->active_tc.msa_fp_status);
+    /* set proper signanling bit meaning ("1" means "quiet") */
+    set_snan_bit_is_one(0, &env->active_tc.msa_fp_status);
 }
-- 
2.7.4

  parent reply	other threads:[~2016-06-26 13:39 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-26 13:38 [Qemu-devel] [PULL 00/10] target-mips queue Leon Alrae
2016-06-26 13:38 ` [Qemu-devel] [PULL 01/10] softfloat: Implement run-time-configurable meaning of signaling NaN bit Leon Alrae
2016-06-26 13:38 ` [Qemu-devel] [PULL 02/10] softfloat: Clean code format in fpu/softfloat-specialize.h Leon Alrae
2016-06-26 13:38 ` [Qemu-devel] [PULL 03/10] softfloat: For Mips only, correct default NaN values Leon Alrae
2016-06-26 13:38 ` [Qemu-devel] [PULL 04/10] softfloat: Handle snan_bit_is_one == 0 in MIPS pickNaNMulAdd() Leon Alrae
2016-06-26 13:38 ` [Qemu-devel] [PULL 05/10] linux-user: Update preprocessor constants for Mips-specific e_flags bits Leon Alrae
2016-06-26 13:38 ` Leon Alrae [this message]
2016-06-26 13:38 ` [Qemu-devel] [PULL 07/10] target-mips: Add abs2008 flavor of <ABS|NEG>.<S|D> Leon Alrae
2016-06-26 13:38 ` [Qemu-devel] [PULL 08/10] target-mips: Add nan2008 flavor of <CEIL|CVT|FLOOR|ROUND|TRUNC>.<L|W>.<S|D> Leon Alrae
2016-06-26 13:38 ` [Qemu-devel] [PULL 09/10] target-mips: Implement FCR31's R/W bitmask and related functionalities Leon Alrae
2016-06-26 13:38 ` [Qemu-devel] [PULL 10/10] target-mips: Add FCR31's FS bit definition Leon Alrae
2016-06-27 11:54 ` [Qemu-devel] [PULL 00/10] target-mips queue Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1466948322-27138-7-git-send-email-leon.alrae@imgtec.com \
    --to=leon.alrae@imgtec.com \
    --cc=aleksandar.markovic@imgtec.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).